Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pylint R0917 error #158

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

FuryMartin
Copy link
Contributor

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fix pylint error R0917 with python>=3.9

Which issue(s) this PR fixes:

Fixes #157

@kubeedge-bot kubeedge-bot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 17, 2024
@kubeedge-bot kubeedge-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 17, 2024
Signed-off-by: Yu Fan <fany@buaa.edu.cn>
@FuryMartin
Copy link
Contributor Author

I resolve the issue #157 by setting max-positional-arguments to 10.

There are other potential solutions, but this one is the most practical. See the discussions in comment #157 (comment)

@hsj576
Copy link
Member

hsj576 commented Oct 18, 2024

This solution is the same as the one discussed in our meeting, and it solves the current problem well.

@hsj576
Copy link
Member

hsj576 commented Oct 18, 2024

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2024
@tangming1996
Copy link

/lgtm

@MooreZheng
Copy link
Collaborator

/lgtm

@MooreZheng MooreZheng requested review from hsj576 and tangming1996 and removed request for Poorunga October 18, 2024 08:28
Copy link
Collaborator

@MooreZheng MooreZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @FuryMartin ! This PR would fix CI errors for several PRs to fit different versions of pylint without ignoring pylint warnings.

In the long run, as discussed at the routine meeting, the design of the "split data" function could be re-visited latter.

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MooreZheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2024
@kubeedge-bot kubeedge-bot merged commit a1fbc04 into kubeedge:main Oct 18, 2024
12 of 13 checks passed
@MooreZheng
Copy link
Collaborator

/approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pylint Errors Due to Compatibility Issues with Pylint3.9
5 participants