-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pylint R0917 error #158
Conversation
Signed-off-by: Yu Fan <fany@buaa.edu.cn>
b249eb8
to
37bf0a6
Compare
I resolve the issue #157 by setting There are other potential solutions, but this one is the most practical. See the discussions in comment #157 (comment) |
This solution is the same as the one discussed in our meeting, and it solves the current problem well. |
/lgtm |
/lgtm |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done @FuryMartin ! This PR would fix CI errors for several PRs to fit different versions of pylint without ignoring pylint warnings.
In the long run, as discussed at the routine meeting, the design of the "split data" function could be re-visited latter.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MooreZheng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/approve |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fix pylint error R0917 with
python>=3.9
Which issue(s) this PR fixes:
Fixes #157