-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Impl for llm edge benchmark suite #150
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: yexiaochuan <yxc2020@foxmail.com>
Signed-off-by: yexiaochuan <yxc2020@foxmail.com>
Signed-off-by: yexiaochuan <yxc2020@foxmail.com>
Signed-off-by: yexiaochuan <yxc2020@foxmail.com>
Signed-off-by: yexiaochuan <yxc2020@foxmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are CI issues that remain to be resolved, see https://github.com/kubeedge/ianvs/actions/runs/11179368172?pr=150
Signed-off-by: yexiaochuan <yxc2020@foxmail.com>
Signed-off-by: yexiaochuan <yxc2020@foxmail.com>
Signed-off-by: yexiaochuan <yxc2020@foxmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI issues are properly tackled. As discussed at the routine meeting, suggestions would be
- Might show a final result (e.g., ranking) in the PR;
- Replace the Chinese statements into English;
- Replace the print with loggers;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Chinese prompt should be removed.
def prefill_latency(y_true, y_pred): | ||
# avg_prefill_latency = y_pred.get('avg_prefill_latency', []) | ||
# return avg_prefill_latency | ||
#TODO 前面所有歌predict_dict 的结果,可以通过下面拿出来,我想把计算平均的过程放在这里,帮我实现 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Chinese prompt should be removed.
Signed-off-by: yexiaochuan <yxc2020@foxmail.com>
@hsj576 Could you please review this PR? I've made several documentation and configuration updates:
Here's screenshot of the benchmark : The results show the changes are working as expected, Let me know if you need any additional information or clarification. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
add Impl for llm edge benchmark suite
Which issue(s) this PR fixes:
#127