Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Impl for llm edge benchmark suite #150

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

add Impl for llm edge benchmark suite #150

wants to merge 10 commits into from
+704 −2

Conversation

XueSongTap
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

add Impl for llm edge benchmark suite

Which issue(s) this PR fixes:

#127

@kubeedge-bot kubeedge-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 24, 2024
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign moorezheng after the PR has been reviewed.
You can assign the PR to them by writing /assign @moorezheng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 24, 2024
add Impl for llm edge benchmark suite
2893646 
Signed-off-by: yexiaochuan <yxc2020@foxmail.com>
yexiaochuan added 2 commits October 3, 2024 19:44
add Impl for llm edge benchmark suite
b6faacc 
Signed-off-by: yexiaochuan <yxc2020@foxmail.com>
Merge changes and resolve conflicts
d341f83 
Signed-off-by: yexiaochuan <yxc2020@foxmail.com>
@kubeedge-bot kubeedge-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 3, 2024
yexiaochuan added 2 commits October 3, 2024 19:58
adapt Impl in core for llm edge benchmark suite
ddd1ec4 
Signed-off-by: yexiaochuan <yxc2020@foxmail.com>
Fix impl on singletast_learning with compression
b42b0c0 
Signed-off-by: yexiaochuan <yxc2020@foxmail.com>
@MooreZheng MooreZheng requested review from hsj576 and removed request for Poorunga October 14, 2024 03:21
MooreZheng
MooreZheng requested changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@MooreZheng MooreZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are CI issues that remain to be resolved, see https://github.com/kubeedge/ianvs/actions/runs/11179368172?pr=150

XueSongTap and others added 4 commits October 24, 2024 13:13
@XueSongTap
Merge branch 'kubeedge:main' into dev
1e62d95
chore: trigger CI
f4b225f 
Signed-off-by: yexiaochuan <yxc2020@foxmail.com>
CI: fix pylint warnings
b25231c 
Signed-off-by: yexiaochuan <yxc2020@foxmail.com>
CI: fix pylint warnings
fab6ac3 
Signed-off-by: yexiaochuan <yxc2020@foxmail.com>
MooreZheng
MooreZheng requested changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@MooreZheng MooreZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI issues are properly tackled. As discussed at the routine meeting, suggestions would be

  1. Might show a final result (e.g., ranking) in the PR;
  2. Replace the Chinese statements into English;
  3. Replace the print with loggers;

hsj576
hsj576 suggested changes Oct 26, 2024
View reviewed changes
Copy link
Member

@hsj576 hsj576 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Chinese prompt should be removed.

examples/llm-edge-benchmark-suite/single_task_bench/testenv/prefill_latency.py Outdated
def prefill_latency(y_true, y_pred):
# avg_prefill_latency = y_pred.get('avg_prefill_latency', [])
# return avg_prefill_latency
#TODO 前面所有歌predict_dict 的结果，可以通过下面拿出来，我想把计算平均的过程放在这里，帮我实现
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Chinese prompt should be removed.

fix: update comments and configuration parameters
17b252e 
Signed-off-by: yexiaochuan <yxc2020@foxmail.com>
@XueSongTap
Copy link
Contributor Author

@hsj576 Could you please review this PR? I've made several documentation and configuration updates:

  • Comment cleanup in basemodel.py
  • Configuration parameter adjustments
  • Documentation improvements in README, including remove chinese part

Here's screenshot of the benchmark ：
image
image

The results show the changes are working as expected,

Let me know if you need any additional information or clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MooreZheng MooreZheng MooreZheng requested changes

@hsj576 hsj576 hsj576 requested changes

Assignees

@MooreZheng MooreZheng

@hsj576 hsj576

Labels
kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XueSongTap @kubeedge-bot @MooreZheng @hsj576