Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

karmor install --env=generic --save should work without kubernetes cluster access #386

Closed
daemon1024 opened this issue Nov 27, 2023 · 4 comments
Closed

karmor install --env=generic --save should work without kubernetes cluster access #386

daemon1024 opened this issue Nov 27, 2023 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@daemon1024
Copy link
Member

With the updates in karmor install It tries to create namespace if not found.

This logic prevents user without kubernetes to just generate the manifest. If --save is used, karmor should not fail if k8s env is not found, it should just go ahead and use the provided env or use the generic env to generate the manifest file.

image
@daemon1024 daemon1024 added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Nov 27, 2023
@sheharyaar
Copy link
Contributor

I would like to work on this one.

@sheharyaar sheharyaar mentioned this issue Nov 28, 2023
Merged
@sheharyaar
Copy link
Contributor

created a PR, please review.

@sheharyaar
Copy link
Contributor

fixed in #388 , can be closed.

@daemon1024
Copy link
Member Author

Thanks @sheharyaar again for handling it. Appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sheharyaar @daemon1024