-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Test Coverage Calculation #845
Comments
Hello, I am new in KubeArmor, I saw this is a Thanks & Regards |
Hey @anonymousr007, This issue would require familiarity with Github Actions in general. Github has an excellent documentation about Github Actions @ https://docs.github.com/en/actions. Our coverage calculation, sends the coverage data to codecov in the test suite here KubeArmor/.github/workflows/ci-test-local.yml Lines 72 to 85 in b38a0a5
We need to move this to a seperate job so as a collective coverage can be calculated. Thanks a lot for showing interest in this. Feel free to ask questions here in this issue thread or on KubeArmor Slack, happy to help out. |
Hello @daemon1024, Thanks for assigning me this issue.
|
This is a step of the job |
Hello @daemon1024, I make a WIP-PR. You guide me in it. Thanks. |
Hey @anonymousr007 Can you link me the PR? I cannot seem to find it. |
Please review it |
Hello! I would love to work on this issue. I have gone through the articles sent above. My understanding of the issue is that the coverage task is currently a step in KubeArmor/.github/workflows/ci-test-local.yml and must be converted to a seperate job, is there any other file that i should be editing? I think removing codecov step from github/workflows/ci-test-ginkgo.yml makes sense. |
Thanks for picking this up @rahulk789.
From my understanding it would still need some form of codecov step that helps aggregating the coverage files across the test suite. I will check the PR and let's continue the discussion there. |
Since Achref's pr (#1029) had removed local tests, we no longer need to combine the code coverage from two ci tests since we have only ginkgo test suit now. That being said, the issue seems no longer relevant and should I close my pr? correct me if I am wrong. @daemon1024 |
Yes @rahulk789, this is still valid. Also we would need a way to generate coverage in Ginkgo test suite itself too. So the work item is still relevant imo. WDYT? |
Working on this one. Please assign. |
Hello! I would love to work on this issue. @rahulk789 |
Feature Request
We should calculate test coverage for tests across all the CI test suites we run.
Is your feature request related to a problem? Please describe the use case.
Currently each coverage calculation is overwritten by the new coverage data in subsequent test suites in a PR.
Describe the solution you'd like
Uploading coverage data to codecov in a seperate job extractiong information from each test suite.
https://about.codecov.io/blog/uploading-code-coverage-in-a-separate-job-on-github-actions/ this article should help out.
The text was updated successfully, but these errors were encountered: