Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hostvisibility information to karmor probe #1078

Closed
legorie opened this issue Jan 29, 2023 · 4 comments · Fixed by #1086
Closed

add hostvisibility information to karmor probe #1078

legorie opened this issue Jan 29, 2023 · 4 comments · Fixed by #1086
Assignees
Labels
enhancement New feature or request

Comments

@legorie
Copy link
Contributor

legorie commented Jan 29, 2023

Feature Request

To add the Host Visibility Level to the karmor probe command Issue #199 of kubearmor-client , we need to modify the karmorprobedata.go file; so that the required data is captured in the /tmp/karmorProbeData.cfg file.

@legorie
Copy link
Contributor Author

legorie commented Feb 2, 2023

Hi @Ankurk99 , I've created a draft PR for the proposed code change, would you please review and give your feedback.

@legorie
Copy link
Contributor Author

legorie commented Feb 2, 2023

Hi @Ankurk99 , Thanks for the feedback on the draft PR, will sign the commit in a new PR.
Have created a draft PR for the kubearmor-client changes, will some example outputs, please have a look and let me know:
kubearmor/kubearmor-client#254

@Ankurk99
Copy link
Member

Ankurk99 commented Feb 3, 2023

Hi @Ankurk99 , Thanks for the feedback on the draft PR, will sign the commit in a new PR.

You don't need to create a new PR for that. You can sign the previous commit with git commit --amend --no-edit -s

@legorie
Copy link
Contributor Author

legorie commented Feb 3, 2023

Thank you Ankur, was able to sign my previous commit using the command..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants