Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(next): introduce the openapi generated client in the next package #152

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

ikadix
Copy link
Collaborator

@ikadix ikadix commented Feb 6, 2024

Now available in github.com/krystal/go-katapult/next is a complete client for the katapult API.
This is generated from the openapi spec.
For now this includes a docker image and a shell script for the build command.

Note

This bumps the following things :

  • Go Version is now minimum v1.20
  • Golangci-lint is now using v1.56
  • checkout action is now v4
  • setup-go action is now v5
  • golangci-lint action is now in use with v4
  • codeclimate action is now v5

goconst has been disabled in test files.
a few changes have been made across the project to remove usage of io/ioutil

Closes #150

@ikadix ikadix requested a review from jimehk March 19, 2024 13:08
@ikadix ikadix marked this pull request as ready for review March 19, 2024 13:09
Copy link
Contributor

@jimehk jimehk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor tweaks to the CI workflows are needed, and I have a question about the bundled OpenAPI schema. Overall looks good and promising though :)

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/nightly.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any script and/or Make target that can update this file from the production URL?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added make targets for getting the schema from the url and for running the generate script

@ikadix ikadix requested a review from jimehk March 19, 2024 13:43
@ikadix ikadix force-pushed the next_subdir branch 2 times, most recently from 5324a73 to d50cc3b Compare March 19, 2024 14:02
Copy link

codeclimate bot commented Mar 19, 2024

Code Climate has analyzed commit 4efa020 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 91.0% (0.0% change).

View more on Code Climate.

@ikadix ikadix merged commit d3f9e3e into main Mar 19, 2024
11 checks passed
@ikadix ikadix deleted the next_subdir branch March 19, 2024 14:24
@replease replease bot mentioned this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare OpenAPI-generated go-katapult client in next branch
2 participants