Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ability to run without ext. services #151

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Added ability to run without ext. services #151

wants to merge 3 commits into from

Conversation

uglrl
Copy link
Contributor

@uglrl uglrl commented Apr 19, 2024 •
edited

Make sure, you have done de following before merging this pull request:

  • Your code is documented using doc comments.
  • You added appropriate logging in your code.
  • You added unit tests to all your implemented functions.
  • You ran cargo format and cargo clippy to format your code and check for improvements.

@uglrl uglrl linked an issue Apr 19, 2024 that may be closed by this pull request
Ability to run without external services for development #135
Open
@uglrl uglrl requested a review from worldofjoni April 19, 2024 17:37
@uglrl uglrl changed the title Added ability to run without ext. services by using preexisting mocks Added ability to run without ext. services Apr 19, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 19, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.06%. Comparing base (5506c5c) to head (6978ec1).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #151   +/-   ##
=======================================
  Coverage   93.06%   93.06%           
=======================================
  Files          38       38           
  Lines        1658     1658           
=======================================
  Hits         1543     1543           
  Misses        115      115

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

worldofjoni
worldofjoni reviewed Apr 19, 2024
View reviewed changes
Copy link
Member

@worldofjoni worldofjoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that you worked on that @uglrl!
I think it would be cleaner to add a command line option to the existing executable for running in isolated demo mode as this is mainly a code duplication. Similar to how the help page or should_migrate is done.
That could be tricky, however, because of the generic type parameters.

@uglrl
Copy link
Contributor Author

uglrl commented Apr 21, 2024

I thought about doing that, but decided against it, since it would make the normal code flow more difficult to read and understand.

@uglrl uglrl self-assigned this Apr 21, 2024
worldofjoni
worldofjoni requested changes Jun 6, 2024
View reviewed changes
Copy link
Member

@worldofjoni worldofjoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright. I think, however, that naming the fine just bin.rs inside the startup folder is very misleading---something like standalone_demo_bin.rs would be clearer.
Also, the usage of this standalone version should be mentioned in the backend readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofjoni worldofjoni worldofjoni requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@uglrl uglrl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to run without external services for development
2 participants
@uglrl @worldofjoni