-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ability to run without ext. services #151
base: main
Are you sure you want to change the base?
Added ability to run without ext. services #151
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #151 +/- ##
=======================================
Coverage 93.06% 93.06%
=======================================
Files 38 38
Lines 1658 1658
=======================================
Hits 1543 1543
Misses 115 115 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice that you worked on that @uglrl!
I think it would be cleaner to add a command line option to the existing executable for running in isolated demo mode as this is mainly a code duplication. Similar to how the help page or should_migrate
is done.
That could be tricky, however, because of the generic type parameters.
I thought about doing that, but decided against it, since it would make the normal code flow more difficult to read and understand. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright. I think, however, that naming the fine just bin.rs
inside the startup folder is very misleading---something like standalone_demo_bin.rs
would be clearer.
Also, the usage of this standalone version should be mentioned in the backend readme.
Make sure, you have done de following before merging this pull request:
cargo format
andcargo clippy
to format your code and check for improvements.