Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(math): add simd int #432

Merged
merged 7 commits into from
Jun 11, 2024
Merged

feat(math): add simd int #432

merged 7 commits into from
Jun 11, 2024

Conversation

chokobole
Copy link
Contributor

Description

This PR implements SimdInt128, SimdInt256, and SimdInt512 that are used for binius.

dongchangYoo
dongchangYoo approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@dongchangYoo dongchangYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ashjeong
ashjeong requested changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@ashjeong ashjeong left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

b1a08ce
Please change the code formatting in this commit's message!

- style: add 'arm_neon.h' and 'immintrin.h' to .clang-format
+ style: add `arm_neon.h` and `immintrin.h` to `.clang-format`

tachyon/math/base/simd_int_unittest.cc Show resolved Hide resolved
tachyon/math/base/simd_int_unittest.cc Show resolved Hide resolved
Insun35
Insun35 approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@Insun35 Insun35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ashjeong
ashjeong requested changes Jun 10, 2024
View reviewed changes
tachyon/math/base/simd_int.h Outdated Show resolved Hide resolved
ashjeong
ashjeong approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@ashjeong ashjeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TomTaehoonKim
TomTaehoonKim reviewed Jun 11, 2024
View reviewed changes
tachyon/math/base/big_int.h Outdated Show resolved Hide resolved
tachyon/math/base/big_int.h Outdated Show resolved Hide resolved
tachyon/math/base/simd_int256_x86.cc Show resolved Hide resolved
tachyon/math/base/simd_int256_x86.cc Show resolved Hide resolved
tachyon/math/base/simd_int512_x86.cc Show resolved Hide resolved
tachyon/math/base/simd_int512_x86.cc Show resolved Hide resolved
TomTaehoonKim
TomTaehoonKim approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@TomTaehoonKim TomTaehoonKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chokobole
style: add arm_neon.h and immintrin.h to .clang-format
514929f
@chokobole
feat(math): add shl and shr operators to BigInt
692f061
@chokobole
feat(math): add SimdInt<128>
a1c4143 
See
https://gitlab.com/IrreducibleOSS/binius/-/blob/84d7b4b0dcbaa09af1ad1799f0731ab286f6981c/crates/field/src/arch/x86_64/m128.rs
and
https://gitlab.com/IrreducibleOSS/binius/-/blob/84d7b4b0dcbaa09af1ad1799f0731ab286f6981c/crates/field/src/arch/aarch64/m128.rs.
@chokobole
feat(math): add SimdInt<256>
0014628 
See
https://gitlab.com/IrreducibleOSS/binius/-/blob/84d7b4b0dcbaa09af1ad1799f0731ab286f6981c/crates/field/src/arch/x86_64/m256.rs.
@chokobole
refac(math): remove redundant casting
2b90039
@chokobole
build(math): add -mavx512f if it is enabled
a2e7c2d
@chokobole
feat(math): add SimdInt<512>
84f7475 
See
https://gitlab.com/IrreducibleOSS/binius/-/blob/84d7b4b0dcbaa09af1ad1799f0731ab286f6981c/crates/field/src/arch/x86_64/m512.rs.
@chokobole chokobole merged commit 8284250 into main Jun 11, 2024
3 checks passed
@chokobole chokobole deleted the feat/add-simd-int branch June 11, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongchangYoo dongchangYoo dongchangYoo approved these changes

@Insun35 Insun35 Insun35 approved these changes

@TomTaehoonKim TomTaehoonKim TomTaehoonKim approved these changes

@ashjeong ashjeong ashjeong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chokobole @dongchangYoo @Insun35 @TomTaehoonKim @ashjeong