Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error when invalid URL passed into krane login #11

Open
david-castaneda opened this issue Aug 18, 2021 · 0 comments
Open

Better error when invalid URL passed into krane login #11

david-castaneda opened this issue Aug 18, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@david-castaneda
Copy link
Member

When running the below command the CLI will error with Error: Unable to authenticate with example.com

$ krane login example.com

This happens because the URL does not contain http or https. We should instead either default to https or throw an error when an invalid URL is passed in.

Fix

Add http or https

$ krane login https://example.com
@david-castaneda david-castaneda added the bug Something isn't working label Aug 18, 2021
@david-castaneda david-castaneda changed the title Better error when invalid URL Better error when invalid URL passed into krane login Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@david-castaneda