Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GeoparquetLoader #74

Merged
merged 9 commits into from
Nov 2, 2022
Merged

Add GeoparquetLoader #74

merged 9 commits into from
Nov 2, 2022

Conversation

RaczeQ
Copy link
Collaborator

@RaczeQ RaczeQ commented Nov 1, 2022

Closes #54

@RaczeQ RaczeQ linked an issue Nov 1, 2022 that may be closed by this pull request
Add GeoparquetLoader #54
Closed
@RaczeQ RaczeQ marked this pull request as ready for review November 1, 2022 14:26
@RaczeQ RaczeQ added the enhancement New feature or request label Nov 2, 2022
Calychas
Calychas requested changes Nov 2, 2022
View reviewed changes
Copy link
Collaborator

@Calychas Calychas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! There are couple of issues that need to be addressed

srai/loaders/geoparquet_loader.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@RaczeQ RaczeQ requested a review from Calychas November 2, 2022 16:48
@RaczeQ RaczeQ merged commit 9629250 into main Nov 2, 2022
@RaczeQ RaczeQ deleted the 54-add-geoparquetloader branch November 2, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calychas Calychas Calychas approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add GeoparquetLoader
2 participants
@RaczeQ @Calychas