Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): add rescue station manager #860

Merged
merged 14 commits into from
Jun 25, 2024
Merged

Conversation

timonmasberg
Copy link
Member

@timonmasberg timonmasberg commented May 7, 2024

Description

Adds functionality for signing in, off and updating signed in rescue stations in a dedicated rescue station manager.

Checklist:

  • The title of this PR and the commit history is conform with
    the Conventional Commits specification.
  • I have performed a self-review of my own code.
  • My changes generate no new warnings, SonarCloud reports no Vulnerabilities, Bugs or Code Smells.
  • I have added tests (unit and E2E if user-facing) that prove my fix is effective or that my feature works,
    Coverage > 80% and not less than the current coverage of the main branch.
  • The PR branch is up-to-date with the base branch. In case you merged main into your feature branch, make sure you have run the latest NX migrations (nx migrate --run-migrations).
  • I have included the reset.d.ts in the tsconfig.lib.json

@timonmasberg timonmasberg self-assigned this May 7, 2024
Copy link

sonarcloud bot commented May 7, 2024

@timonmasberg timonmasberg requested a review from JSPRH May 7, 2024 21:02
Copy link
Contributor

@JSPRH JSPRH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice implementation! Left some comments and suggestions

@timonmasberg timonmasberg enabled auto-merge (squash) June 25, 2024 19:04
Copy link

sonarcloud bot commented Jun 25, 2024

@timonmasberg timonmasberg requested a review from JSPRH June 25, 2024 19:08
@timonmasberg timonmasberg merged commit 83cc58f into main Jun 25, 2024
5 checks passed
@timonmasberg timonmasberg deleted the feat/rescue-stations branch June 25, 2024 21:09
@timonmasberg
Copy link
Member Author

🎉 This PR is included in version 1.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants