Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bootstrap mongodb #136

Merged
merged 9 commits into from
Apr 16, 2023
Merged

feat: bootstrap mongodb #136

merged 9 commits into from
Apr 16, 2023

Conversation

timonmasberg
Copy link
Member

@timonmasberg timonmasberg commented Apr 13, 2023 •
edited
Loading

This PR introduces MongoDB as the primary Database, as well as:

  • Migration scripts that run after next deployments;
  • A script and a data structure for importing development data (this data can be used for development and for e2e tests);
  • A CLI script that makes it easy for developers to start a MongoDB locally with development data;
  • An ADR about why we choose MongoDB.

@timonmasberg timonmasberg self-assigned this Apr 13, 2023
@timonmasberg timonmasberg force-pushed the feat/mongo-db branch 12 times, most recently from 9e1bb08 to a3f3fbc Compare April 13, 2023 22:51
@timonmasberg timonmasberg marked this pull request as ready for review April 14, 2023 09:41
@timonmasberg timonmasberg requested a review from JSPRH April 14, 2023 09:41
JSPRH
JSPRH reviewed Apr 14, 2023
View reviewed changes
Copy link
Contributor

@JSPRH JSPRH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice! Good job! Just some nits and thoughts.

tools/db/data/import.ts Show resolved Hide resolved
tools/db/kordis-db.sh Outdated Show resolved Hide resolved
tools/db/README.md Outdated Show resolved Hide resolved
tools/db/README.md Outdated Show resolved Hide resolved
tools/db/README.md Outdated Show resolved Hide resolved
tools/db/README.md Show resolved Hide resolved
tools/db/README.md Outdated Show resolved Hide resolved
tools/db/README.md Outdated Show resolved Hide resolved
tools/db/kordis-db.sh Outdated Show resolved Hide resolved
JSPRH
JSPRH reviewed Apr 16, 2023
View reviewed changes
tools/db/README.md Outdated Show resolved Hide resolved
timonmasberg and others added 2 commits April 16, 2023 21:09
@timonmasberg @JSPRH
chore: add link to template file
df36121 
Co-authored-by: Jasper Herzberg <JSPRH@users.noreply.github.com>
@timonmasberg
Merge branch 'main' into feat/mongo-db
706444a
@sonarcloud
Copy link

sonarcloud bot commented Apr 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@timonmasberg timonmasberg merged commit 0affebe into main Apr 16, 2023
@timonmasberg timonmasberg deleted the feat/mongo-db branch April 16, 2023 19:58
@timonmasberg
Copy link
Member Author

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JSPRH JSPRH JSPRH approved these changes

Assignees

@timonmasberg timonmasberg

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timonmasberg @JSPRH