✨ Support multi-container tasks.

[jortel]

Motivation: Support analyzer (addon) with multiple provider images.

Add support multi-container tasks. To accomplish this, the addon spec will contain a field named pod will be a pod (Spec) template instead of separate fields for image, pull policy and resources.

Proposed addon CRD changes:

- image:
- imagePullPolicy:
- resources:

+ container (core.v1.Container):

The pod is a core.v1.PodSpec.

The task manager will need to aggregate container status and errors on the Task.

---

Concerns:

• When a pod has multiple containers, the phase is Running until all containers have terminated. For addons, it's assumed that one of the containers is the main container and likely that the additional containers cannot be reliably terminated.
  • How will the main addon container be identified? Perhaps container[0]?
  • How to kill non-main containers? The most proper way is for the pod to be deleted. To implement this without losing troubleshooting information, the task manager would need to grab a snapshot of the pod (including status) and logs. killing the non-main containers (see: sharedProcessNamespace) introduces complexities and challenges to do reliably.

Notes:

• Sidecar container (feature) not introduced in k8s until: beta 1.28, released 1.29.

Links

• SideCar containers.
• shareProcessNamespace option.

[konveyor-ci-bot]

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

[jortel]

Better captured by #599