Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#define AES_KEYLEN bites with SAMD5 compiler #125

Open
vogt31337 opened this issue Feb 14, 2019 · 4 comments
Open

#define AES_KEYLEN bites with SAMD5 compiler #125

vogt31337 opened this issue Feb 14, 2019 · 4 comments

Comments

@vogt31337
Copy link

Hi,

your tiny AES works flawlessly on an Arduino Feather M4 Express (AVR SAMD5 architecture).
But the #define AES_KEYLEN get's redefined in the include files from the compiler. The SAMD5 has a hardware AES module and defines it's own AES_KEYLEN.

So maybe rename some things in this library?

BR

@DamonHD
Copy link

DamonHD commented Feb 14, 2019

This would be the sort of thing that namespaces and static constexpr are designed to gracefully sidestep...

Rgds

Damon

@vogt31337
Copy link
Author

I don't know maybe. But when I include tiny-AES-c the compiler complains. And I thought changing the compiler delivered includes wouldn't be the right spot...

@kokke
Copy link
Owner

kokke commented Mar 18, 2019

Hi @vogt31337 and thanks for your interest in this project.

As I usually do, I agree with @DamonHD on this point.

So maybe rename some things in this library?

I'll be happy to review a PR with any naming changes you could have in mind :)

@vogt31337
Copy link
Author

I also agree with @DamonHD, but I don't have enough time / knowledge to implement this.
So as a matter of fact I would just change the name to something like TINY_AES_KEYLEN...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants