You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm pretty strict about where to put my energy, and in code reviews, we should go the same and not slow down things.
Yet I care about development and try to peak on a conversation in pull requests about how things are going; I noticed frequent behaviour happening, like issues gaining a lot of comments or bad practice repeating over again.
Even I respect that if someone gives you a code review once, that person doesn't want to be forced to provide you with a review if you can't learn in previous PRs and repeat mistakes again. I feel it must be annoying.
I have a few options for how to solve this:
start respecting the time for PR to be delivered and the amount of discord happening in PR; if it takes too long (3d+/20 comments), it's ok to close it and handover started work (if reusable) to someone else. We are playing against time, and the most experienced contributors should tackle things in a fast manner. Leave it on the less experienced person and asking for more than one code review is a resource eater from our side energy, context switching, and educating others. I see everyone value peer learning, yet if the knowledge gap is the huge and less experienced people won't learn, it's wasted time from our side.
lower payout - I'm ok paying half or a third if a person is still willing to deliver it anyway.
probably start adding a label beginner/expert, OR p3 will be less sensitive to this than p2 issues.
I still value everyone's contribution, yet we are already delayed on some things, and if we won't deliver some things ahead of time, we won't manage to get strong traction on market enough to survive the downturn. That's the rule of market survival.
It is what it is.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
I'm pretty strict about where to put my energy, and in code reviews, we should go the same and not slow down things.
Yet I care about development and try to peak on a conversation in pull requests about how things are going; I noticed frequent behaviour happening, like issues gaining a lot of comments or bad practice repeating over again.
Even I respect that if someone gives you a code review once, that person doesn't want to be forced to provide you with a review if you can't learn in previous PRs and repeat mistakes again. I feel it must be annoying.
I have a few options for how to solve this:
I still value everyone's contribution, yet we are already delayed on some things, and if we won't deliver some things ahead of time, we won't manage to get strong traction on market enough to survive the downturn. That's the rule of market survival.
It is what it is.
Ref
Beta Was this translation helpful? Give feedback.
All reactions