Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow duplicate choices in snapshots #3757

Merged
merged 2 commits into from
Apr 5, 2022

Conversation

jnm
Copy link
Member

@jnm jnm commented Apr 5, 2022

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Make sure that your code lints and that you've followed our coding style
  5. Write a description of your work suitable for publishing on our forum
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes

Description

Relaxes the pyxform requirement for uniqueness among choice values (also called choice names) for existing forms. This prevents failures when trying to edit submissions for these forms or retrieve these forms' XForm XML.

Related issues

Fixes #3751

jnm added 2 commits April 5, 2022 17:45
when invoking pyxform for internal XLSForm to XForm transformations, so
that older forms are not broken. Do not add this setting when deploying
forms, and do not contradict any existing setting in a form.
@joshuaberetta joshuaberetta merged commit fb0a124 into master Apr 5, 2022
@joshuaberetta joshuaberetta deleted the allow-duplicate-choices-in-snapshots branch April 5, 2022 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes in pyxform behavior break submission editing
2 participants