Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mismatched labels and translations error for forms using multiple languages and select_one_from_file or select_multiple_from_file #323

Merged
merged 4 commits into from
Jun 17, 2024

Conversation

jnm
Copy link
Member

@jnm jnm commented Jun 15, 2024

Correct the mistake in #321 that merged two constants both named MEDIA_TYPES together. In reality, one constant was used for media column names, and the other for question types that collect attachments. The former is now renamed to MEDIA_COLUMN_NAMES.

The utility function formpack.utils.bugfix.repair_file_column_content_in_place() is also provided to repair content that was damaged by this mistake.

Fixes #322. For more details, please read the description of that issue.

jnm added 3 commits June 15, 2024 11:08
`Mismatched labels and translations` error when attempting to load a
schema that contains multiple languages as well as a
`select_one_from_file` or `select_multiple_from_file` that has been
expanded to have a `file` column as performed by #314
types!

This fixes #322 for new schemas, but doesn't yet handle existing schemas
that have a superfluous `None` translation
This needs to be applied to existing content
@jnm jnm marked this pull request as ready for review June 17, 2024 04:51
@jnm jnm merged commit 451df4c into main Jun 17, 2024
3 checks passed
@jnm jnm deleted the 322-export-failure branch June 17, 2024 04:53
jnm added a commit to kobotoolbox/kpi that referenced this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Mismatched labels and translations" export failure when select_*_from_file present in multi-langauge forms
1 participant