Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve perforamance of _pluck_uniq_cols #216

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Improve perforamance of _pluck_uniq_cols #216

wants to merge 9 commits into from

Commits on May 2, 2020

  1. Improve perforamance of _pluck_uniq_cols 

    Use a set instead of an OrderedDict with empty values for gathering
unique values.

O(n^2) -> O(nlogn)
    @mlazowik
    mlazowik committed May 2, 2020
    Configuration menu
    Copy the full SHA
    2eedaa7 View commit details
    Browse the repository at this point in the history

  2. Fix: preserve order of columns in _get_special_survey_cols

    @mlazowik
    mlazowik committed May 2, 2020
    Configuration menu
    Copy the full SHA
    7de1069 View commit details
    Browse the repository at this point in the history

  3. Fix: preserve the original order of columns instead of sorting

    @mlazowik
    mlazowik committed May 2, 2020
    Configuration menu
    Copy the full SHA
    68987d1 View commit details
    Browse the repository at this point in the history

  4. Add comment explaining the unusual code

    @mlazowik
    mlazowik committed May 2, 2020
    Configuration menu
    Copy the full SHA
    db116cc View commit details
    Browse the repository at this point in the history

  5. Use an existing OrderedSet library instead of custom implementation

    @mlazowik
    mlazowik committed May 2, 2020
    Configuration menu
    Copy the full SHA
    3949477 View commit details
    Browse the repository at this point in the history

  6. Revert "Use an existing OrderedSet library instead of custom implemen… 

    …tation"

This reverts commit 3949477.
    @mlazowik
    mlazowik committed May 2, 2020
    Configuration menu
    Copy the full SHA
    91e9011 View commit details
    Browse the repository at this point in the history

  7. Extract OrderedSet()

    @mlazowik
    mlazowik committed May 2, 2020
    Configuration menu
    Copy the full SHA
    23e53be View commit details
    Browse the repository at this point in the history

  8. Fix: OrderedSet.add

    @mlazowik
    mlazowik committed May 2, 2020
    Configuration menu
    Copy the full SHA
    c431df9 View commit details
    Browse the repository at this point in the history

  9. Fix: OrderedSet.add order

    @mlazowik
    mlazowik committed May 2, 2020
    Configuration menu
    Copy the full SHA
    b37f9e6 View commit details
    Browse the repository at this point in the history