-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On cluster build: Not working for a golang function #809
Comments
@Shashankft9 you are right, that's the problem. @lance did this PR: boson-project/packs#5 We just need to set the proper builder for Golang based func projects. Willling to tackle this? Thanks! |
sure, related question - something like the PR you linked has to be done for rust runtime as well I believe? Since it uses one paketo community buildpack which is not included in the the paketo buildpacks builder. Also, will there be more custom builders for future enhancements/new language runtimes? What are your opinions about somehow keeping the builder same across but adding and using buildpacks on need-basis? (if this is even possible with on cluster build support). I am thinking about what would happen if a provider already uses some custom buildpacks and they want to plug it in func builds. IIUC all this would be for on cluster builds only, since there is a way to plug in custom buildpacks in the func.yaml which can be used to do local builds. Sorry for the long edit, if you think this should be transferred somewhere else, I can do that as well - thank you! |
Do you think you can handle Rust as well? Thanks!
This is a good question, we need to tackle this? Maybe the global configuration could solve this? Users could overwrite default buildpacks there? WDYT? |
Sure! but we will need to host the rust builder somewhere (ref: https://github.com/paketo-community/rust#a-builder), just like the go builder. I don't know how I can do that, any pointers?
I think this might not be an immediate issue, but might come up for users later who are already familiar with buildpacks and want to use their custom ones in on cluster builds, maybe the global configuration work will address some of it - I will open a separate issue for this |
This issue is stale because it has been open for 90 days with no |
/remove-lifecycle stale |
This issue is stale because it has been open for 90 days with no |
/remove-lifecycle stale |
This issue is stale because it has been open for 90 days with no |
/remove-lifecycle stale |
This issue is stale because it has been open for 90 days with no |
/remove-lifecycle stale |
@jrangelramos do you think we can get an e2e test for this? I think it should work when using |
Yea. I think so. I can manage that. |
I am following this doc: https://github.com/knative-sandbox/kn-plugin-func/blob/main/docs/guides/on-cluster-build.md and have compiled func cli from main branch.
I created function in go language.
When I am doing
func deploy
, it fails with:Upon taking a look at
step-create
, it says:I wonder if its because go functions require some scaffolding with boson go buildpack and that might not be included in the
create
step ofbuildpacks
task here: https://github.com/raw/tektoncd/catalog/master/task/buildpacks/0.3/buildpacks.yamlThe text was updated successfully, but these errors were encountered: