-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add Apple M1 build in cross-platform target #932
Conversation
Might fix: knative#377 Signed-off-by: Lance Ball <lball@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Lance Ball <lball@redhat.com>
Note: to really support m1 we need make our images mult-arch. |
Codecov Report
@@ Coverage Diff @@
## main #932 +/- ##
=======================================
Coverage 43.85% 43.85%
=======================================
Files 55 55
Lines 5163 5163
=======================================
Hits 2264 2264
Misses 2576 2576
Partials 323 323 Continue to review full report at Codecov.
|
@matejvasek ty for the quick feedback. Do you think this is sufficient for #377? Do we need to care about any of the images? I'm thinking we don't but would like your thoughts. |
btw: will our OpenShift always run on amd64? Don't we support some power pc or sparc on server? |
Can you elaborate? I don't really understand the issue here. |
That's sounding familiar, but I'm not exactly sure. |
I think that for instance |
@lance you had to run docker on your Linux machine and connect to it to make it work on m1, right? |
Yes, I have had success on my new Mac with Docker Desktop.
Yep - or use a podman daemon on a remote linux machine. |
But maybe qemu could save this somehow? |
But we would have to update the dock how to setup qemu. |
Shouldn't we also update Release Github Actions in this PR? |
|
So it works OOB? |
Not need to set up |
Signed-off-by: Lance Ball <lball@redhat.com>
Yes!
|
Interesting... do you have |
Also is it as fast as build on amd64? |
No it's painfully slow. And to document some of our conversation that wasn't included here, it seems that Docker Desktop does use QEMU under the covers. When running a build, we can see it in action.
|
I think that one qemu process is ok it's aarch64, is there any other process that is amd64? |
Actually that amd64 emulation would probably run withing the aarch64 qemu. So we cannot see it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of duplicate lines to remove in the (admitedly cryptic) make-fu
Signed-off-by: Lance Ball <lball@redhat.com>
/lgtm |
/unhold |
* chore: add Apple M1 build in cross-platform target Might fix: knative#377 Signed-off-by: Lance Ball <lball@redhat.com> * fixup: review feedback/better names Signed-off-by: Lance Ball <lball@redhat.com> * fixup: adjust release workflow Signed-off-by: Lance Ball <lball@redhat.com> * fixup: remove duplicate Signed-off-by: Lance Ball <lball@redhat.com>
This commit adds a
make
target fordarwin-arm64
and changes the originaldarwin
target todarwin-amd64
.Might fix: #377
/kind chore
Signed-off-by: Lance Ball lball@redhat.com
Release Note