Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add a URL output type for func describe #389

Merged
merged 2 commits into from
Jun 18, 2021
Merged

feat: add a URL output type for func describe #389

merged 2 commits into from
Jun 18, 2021

Conversation

jcrossley3
Copy link
Contributor

Fixes #387

zroubalik
zroubalik reviewed Jun 16, 2021
View reviewed changes
Copy link
Contributor

@zroubalik zroubalik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just a minor nit in output.

cmd/describe.go Outdated Show resolved Hide resolved
@jcrossley3 @zroubalik
Add linefeed
d42fc15 
Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com>
zroubalik
zroubalik approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zroubalik zroubalik changed the title Added a URL output type for func describe feat: add a URL output type for func describe Jun 16, 2021
lance
lance approved these changes Jun 16, 2021
View reviewed changes
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!

@zroubalik zroubalik merged commit 947fcaa into knative:main Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance lance lance approved these changes

@zroubalik zroubalik zroubalik approved these changes

@lkingland lkingland Awaiting requested review from lkingland

@matejvasek matejvasek Awaiting requested review from matejvasek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need a programmatic way to get deployed function's URL
3 participants
@jcrossley3 @lance @zroubalik