Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add homepage to Podspec #16

Open
xuio opened this issue Mar 5, 2021 · 3 comments
Open

Add homepage to Podspec #16

xuio opened this issue Mar 5, 2021 · 3 comments

Comments

@xuio
Copy link

xuio commented Mar 5, 2021

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch @klarna/react-native-zlib@1.0.1 for the project I'm working on.

this fixes issue #8

Here is the diff that solved my problem:

diff --git a/node_modules/@klarna/react-native-zlib/ios/RNReactNativeZlib.podspec b/node_modules/@klarna/react-native-zlib/ios/RNReactNativeZlib.podspec
index e7934a2..f501afb 100644
--- a/node_modules/@klarna/react-native-zlib/ios/RNReactNativeZlib.podspec
+++ b/node_modules/@klarna/react-native-zlib/ios/RNReactNativeZlib.podspec
@@ -6,7 +6,7 @@ Pod::Spec.new do |s|
   s.description  = <<-DESC
                   RNReactNativeZlib
                    DESC
-  s.homepage     = ""
+  s.homepage     = "klarna.com"
   s.license      = "MIT"
   # s.license      = { :type => "MIT", :file => "FILE_LICENSE" }
   s.author             = { "author" => "author@domain.cn" }

This issue body was partially generated by patch-package.

@pcurc
Copy link

pcurc commented Mar 24, 2021

I'd be very interested to see this patch implemented - CocoaPods refuses to install the current module as written and this solves the issue.

@xhirazi
Copy link

xhirazi commented Jul 5, 2021

@xuio @pcurc
use this https://www.npmjs.com/package/rn-gzip

@xuio
Copy link
Author

xuio commented Jul 5, 2021

@xhirazi Thanks! That is really helpful!

We previously had to patch this package manually to support GZIP's additions to zlib, but this makes things much easier!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants