Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating errcheck to go/analysis #165

Closed
vitarb opened this issue May 1, 2019 · 2 comments
Closed

Migrating errcheck to go/analysis #165

vitarb opened this issue May 1, 2019 · 2 comments

Comments

@vitarb
Copy link

vitarb commented May 1, 2019

It looks like x/tools/go/analysis is quickly becoming a new standard for writing static analysis in go. Being natively supported by tools like bazel's nogo it provides invaluable ability to unify all linters and perform static analysis at the build time.
errcheck being one of the most useful linters outside of go vet should greatly benefit from unification.

Are there any plans for doing this work or would you welcome contributions in this area?
@vitarb vitarb changed the title Migrating errcheck to use go/analysis Migrating errcheck to go/analysis May 1, 2019
@echlebek
Copy link
Collaborator

echlebek commented Jul 7, 2020

There aren't any plans to rewrite the tool. Contributions are welcome, but I have to wonder if integrating this library would lead to a wholly different program?

@dtcaciuc dtcaciuc mentioned this issue Mar 28, 2021
Merged
@dtcaciuc
Copy link
Collaborator

The package now provides errcheck.Analyzer; see README for short description and API stability disclaimer. This makes errcheck go/analysis-compatible while keeping the existing CLI unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dtcaciuc @vitarb @echlebek