Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kola/test/docker: enable docker.selinux for all arch #225

Merged
merged 2 commits into from
Sep 3, 2021

Conversation

tormath1
Copy link
Contributor

@tormath1 tormath1 commented Sep 3, 2021

SELinux is now supported on ARM64

Signed-off-by: Mathieu Tortuyaux mtortuyaux@microsoft.com

Testing done

# get image from SELinux PR https://github.com/kinvolk/coreos-overlay/pull/1245
wget https://storage.googleapis.com/flatcar-jenkins/developer/developer/boards/arm64-usr/2021.09.01%2Bdev-flatcar-master-3470/flatcar_production_image.bin.bz2
sudo ./bin/kola run --channel alpha --board arm64-usr --key ${HOME}/.ssh/id_rsa.pub -k -b cl --qemu-bios ./flatcar_production_qemu_uefi_efi_code.fd  -p qemu --qemu-image ./flatcar_production_image.bin docker.selinux

@tormath1 tormath1 requested a review from a team September 3, 2021 10:14
@tormath1 tormath1 self-assigned this Sep 3, 2021
ClusterSize: 1,
Name: "docker.selinux",
Distros: []string{"cl"},
Channels: []string{"alpha", "beta"},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While at it we should switch this to using MinVersion or we will forget this when the next channel transition happens

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MinVersion: semver.Version{Major: 2942}, should mean everything newer, including the current beta?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not MinVersion: semver.Version{Major: 2984}, ? SELinux changes will be available only in the next alpha 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, I just thought about the existing beta value

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an edge case actually:

  • SELinux amd64 is available on alpha/beta
  • SELinux arm64 is only on main atm

so:

  • MinVersion: semver.Version{Major: 2942},: will make the test fail on arm64 for both beta / alpha
  • MinVersion: semver.Version{Major: 2984},: will make the test disappears for amd64 for both beta / alpha

Copy link
Member

@pothos pothos Sep 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, MinVersion: semver.Version{Major: 2984}, is the right one :D (Edit: no, see below)

Copy link
Member

@pothos pothos Sep 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to skip the tests than have them fail when doing a bugfix release (Edit: no, see below)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, wait, didn't get it fully when reading the first time… we have no way to specify the version per architecture, complicated. I think it's ok to let it fail for arm64 on Alpha bugfix releases then and use 2942.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok done with 2942 :)

SELinux is now supported on ARM64

Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
@tormath1 tormath1 merged commit f6bb23c into flatcar-master Sep 3, 2021
@tormath1 tormath1 deleted the tormath/docker-selinux-arm branch September 3, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants