kola/harness: detect LTS major version #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pothos
force-pushed
the
kai/lts-nightly
branch
2 times, most recently
from
927f7d4
to
102125e
Compare
|
@jepio I saw your PR too late, but took your changes now while simplifying the shell command. |
The LTS branch is flatcar-lts-MAJOR and only flatcar-MAJOR branch names were considered which let to an invalid major version "lts" being parsed. Take the element after either "flatcar" or "flatcar-lts" when splitting on "-". The full build ID is "dev-flatcar(-lts)-MAJOR-nightly-XYZ".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LTS branch is flatcar-lts-MAJOR and only flatcar-MAJOR branch names
were considered which let to an invalid major version "lts" being
parsed.
Take the element after either "flatcar" or "flatcar-lts" when splitting
on "-". The full build ID is "dev-flatcar(-lts)-MAJOR-nightly-XYZ".
How to use
Testing done
Tested with a nightly build for
flatcar-2955