kola: support nightly version in version comparisons #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pothos
force-pushed
the
kai/kola-minimum-version
branch
from
97381df
to
373a68d
Compare
krnowak
reviewed
Aug 2, 2021
pothos
force-pushed
the
kai/kola-minimum-version
branch
3 times, most recently
from
e0ad4a1
to
7ce6af4
Compare
tormath1
changed the title
tormath1
approved these changes
Aug 2, 2021
The nightly version is the build date but the build ID has the branch reference. To support the version comparion for nightly builds we need to generate a version for the "main" branch and the major version branches that is higher than the current release version. Use 999999.99.99 as version in the semantic version checks for nightly builds from the "main" branch or custom dev builds and use MAJOR.99.99 as version for nightly builds from the release branch.
pothos
force-pushed
the
kai/kola-minimum-version
branch
from
7ce6af4
to
2def1ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kola: support nightly version in version comparions
The nightly version is the build date but the build ID has the branch
reference. To support the version comparion for nightly builds we need
to generate a version for the "main" branch and the major version
branches that is higher than the current release version.
Use 999999.99.99 as version in the semantic version checks for nightly
builds from the "main" branch or custom dev builds and use MAJOR.99.99
as version for nightly builds from the release branch.
kola/tests/misc/verity: run test based on major version
How to use
Testing done