Improve AWS subcommands in ore, support AWS Pro downloading in cork, adjust LTS handling in plume #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AMIs were not published anyway and just used for testing.
The AWS Pro images are a different OEM type with a _pro suffix.
sayanchowdhury
approved these changes
Dec 11, 2020
platform/api/aws/images.go
Outdated
| @@ -349,7 +349,7 @@ func (a *API) deregisterImageIfExists(name string) error { | |||
| } | |||
|
|
|||
| // Remove all uploaded data associated with an AMI, also in other given regions. | |||
| func (a *API) RemoveImage(name, s3BucketName, s3ObjectPath string, otherRegions []string) error { | |||
| func (a *API) RemoveImage(name, imageName, s3BucketName, s3ObjectPath string, otherRegions []string) error { | |||
There was a problem hiding this comment.
It would be good to rename the name to amiName to make it more verbose.
A mismatched snapshot name resulted in "ore aws upload --force" not really reuploading but just reusing the existing AMI. Use the correct snapshot name to ensure that --force works.
An image uploaded by "ore aws upload" could only be deleted manually. Add a subcommand to delete the image again.
pothos
force-pushed
the
kai/lts-and-pro
branch
from
c3d7cce
to
38c01e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AMIs were not published anyway and just used for testing.
The AWS Pro images are a different OEM type with a _pro suffix.
A mismatched snapshot name resulted in "ore aws upload --force" not
really reuploading but just reusing the existing AMI.
Use the correct snapshot name to ensure that --force works.
An image uploaded by "ore aws upload" could only be deleted manually.
Add a subcommand to delete the image again.
How to use
In conjunction with flatcar/scripts#106 and from Jenkins.
Testing done
Tested only uploading and deleting regular AWS images: