New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

max_common is wrong? #8

Open

cswhjiang opened this issue Jan 1, 2018 · 1 comment

cswhjiang commented Jan 1, 2018 •

edited

Loading

It seems that the max_common (https://github.com/kimiyoung/review_net/blob/master/code_caption/comp_prefix.lua#L2) is not correct. To access the ith element in the string s1, s1:sub(i,i) should be used. Not s1[i]. s1[i] is always nil. The correct CS-k metrics should be:

MODEL_FILE	reason.step8.litrans0.after1.merge0.model
#train batches	1074	#test batches	133
word_cnt	12859	token_cnt	20395
copy done
1	0.58108726620882
2	0.67359954807709
3	0.71993582684564
4	0.7437227668029
5	0.76213157058093
copy done
test loss	5.0341047093877

The text was updated successfully, but these errors were encountered:

Owner

kimiyoung commented Jan 2, 2018

Thanks for the good catch, and sorry about any inconvenience.
I have fixed the bug, and will update the results soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment