-
Notifications
You must be signed in to change notification settings - Fork 115
Conversation
Signed-off-by: Chun Lin Yang <clyang@cn.ibm.com>
Can one of the admins verify this patch? |
@clyang82 Thanks for your contribution, I think that makes sense. Would it make sense here to do a composite key, that starts with e.g. 'io.kiali' to indicate that whatever you use it points to Kiali? |
adding @mtho11 as reviewer |
+1 I think we should have the root key be more specific to "kiali" regardless of context root (why not just rename "root" to "kiali", for example?") |
src/store/ConfigStore.ts
Outdated
@@ -16,8 +16,11 @@ import { INITIAL_STATUS_STATE } from '../reducers/HelpDropdownState'; | |||
|
|||
declare const window; | |||
|
|||
const webRoot = (window as any).WEB_ROOT ? (window as any).WEB_ROOT : undefined; | |||
const persistKey = webRoot && webRoot !== '/' ? webRoot.substring(1) : 'root'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great idea! could we also maybe change 'root' to 'kiali-root'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mtho11 Thanks for your comments. I would like to using 'kiali' as a prefix.
@pilhuhn That is great idea to using composite key to ensure it is unique. I would like to using 'kiali' as a prefix. Thanks. |
Signed-off-by: Chun Lin Yang <clyang@cn.ibm.com>
Signed-off-by: Chun Lin Yang clyang@cn.ibm.com
** Describe the change **
right now, the persist key is hard-coded as
root
in config. it may conflict with other application which is also usingpersist:root
as key in localStorage. Since Kaili supports customize base path (fixed in #569) so that we should get the WEB_ROOT instead of hardcode.** Backwards compatible? **
Yes