-
Notifications
You must be signed in to change notification settings - Fork 18
suggest replacing all files xxxx_Impl.h by xxxx.cpp #22
Comments
Have a look at
I forget to convert this to Will publish new release to deal with this, but never going back to |
thank you for that info. |
The new MySQL_MariaDB_Generic releases v1.7.0 has just been published. Your contribution is noted in Contributions and Thanks Please test one of the new examples, such as multiFileProject_Ethernet, to see how to do for multiple-file projects to avoid Best Regards, PS: I'm excited and so busy to follow up with your suggestions, but still wish you provide many more ;-)) Releases v1.7.0
|
thank you very much. I will try to keep up with the suggestions and fixes. Are you going to publish it soon? so I can install it via Arduino. Let me try the 1.7.0 and stress it and I will let you know. thank you very much |
Already published v1.7.0. You can install from Arduino or PlatformIO now. |
strange.....arduino shows me the latest one as 1.6.1, and not the 1.7.0 |
It takes some time to propagate to Library Manager (some hours ??). You can download directly from the GitHub, then unzip. PS: You have a good talent to finding bugs, especially using your stress tests. I wish you can use that to spots the bugs in my other libraries. |
yes, sure. Which other libraries you need to test? one detail I forgot to mention.....since 1.6.0, when I update this library on Arduino IDE, it asks me if I want to update just this library or the dependencies also (it shows me a list of 5 dependency libraries). If I choose all dependencies, it successfully updates ONLY this library and fails with an error. Maybe this is caused by some dependency you marked that are ment to be for platformio? I will screenshot it next time. |
Because this library is written to support too many boards, shields, libraries, architectures and platforms, I have to add all of them to the list. Many users complaint long ago if not. So better extra than nothing. Sometimes, the Arduino IDE and/or PIO is not intelligent enough to select the correct libraries for that architectures / platform. So, you have to manually install the necessary libraries, at least you know the list. |
You can see my full list of 130+ libraries in KH Libraries Just jump into any library you're interested and possibly will use in your project, then click |
May I suggest suggest replacing all files xxxx_Impl.h by xxxx.cpp?
Having all code in .h header files creates linking errors if you "#include <MySQL_Generic>" from different .cpp modules of the same project, because the linker will find several times functions with the same name.
Having a proper .h corresponding to a proper .cpp, you can include the .h several times from everywhere without causing lining problems.
It happened to me.
Just a suggestion.
The text was updated successfully, but these errors were encountered: