Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ResNet [18, 34] to keras.applications #15269

Closed
innat opened this issue Aug 28, 2021 · 11 comments
Closed

Add ResNet [18, 34] to keras.applications #15269

innat opened this issue Aug 28, 2021 · 11 comments
Assignees
Labels
type:feature The user is asking for a new feature.

Comments

@innat
Copy link

innat commented Aug 28, 2021

System information.

TensorFlow version (you are using): 2.5
Are you willing to contribute it (Yes/No): Yes.

Describe the feature and the current behavior/state.

Currently, we have ResNet 50/101/152. However, sometimes it's needed to test the idea initially with some small models quickly and for that, if we want to choose a res-net-based model we can't just pick 50 because it's still too heavy to train. That's why we think it would be nice to have resnet18 and resnet34 as well with the keras packages.

Will this change the current api? How?
Yes. It will include

from tensorflow.keras.applications.resnet18 import ResNet18
from tensorflow.keras.applications.resnet34 import ResNet34

Who will benefit from this feature?
ML engineers and researcher who uses tf.keras.

Others
Others implementation: https://github.com/qubvel/classification_models

@innat innat added the type:feature The user is asking for a new feature. label Aug 28, 2021
@quantumalaviya
Copy link

Can I work on this?

@innat
Copy link
Author

innat commented Aug 29, 2021

@quantumalaviya of course. Just send a PR. It should be welcomed.

@quantumalaviya
Copy link

So, I just wrote the code but I notice some differences in the number of parameters when compared to https://github.com/qubvel/classification_models. Any suggestions on how to add weights?

@rchao
Copy link
Contributor

rchao commented Sep 2, 2021

Thanks for opening the issue. Can you provide a paragraph as a proposal for justifying adding this model? If you can provide some context of how widely this is used or some citation, that would be helpful.

@innat
Copy link
Author

innat commented Sep 6, 2021

@rchao
FYI, These have been asked before. #151

@quantumalaviya could you please check out this implementation, it already exists in keras-contrib but is not included in keras.

@breadbread1984
Copy link

https://github.com/breadbread1984/resnet18-34 . you may try this implement.

@KaleabTessera
Copy link

+1

@innat
Copy link
Author

innat commented Apr 1, 2022

@breadbread1984 It would be nice to send PR. WDYT?

@innat
Copy link
Author

innat commented Apr 5, 2022

@LukeWood Will the new model be added to keras.application or keras_cv?

@LukeWood
Copy link
Contributor

LukeWood commented Apr 5, 2022

for now keras.applications.

@zaccharieramzi
Copy link

In the end, we added the model in keras-cv, see this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature The user is asking for a new feature.
Projects
None yet
Development

No branches or pull requests

7 participants