Fixing conversion of box formats on the original boxes #2213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divyashreepathihalli
requested changes
Dec 8, 2023
|
@ariG23498 I think we should update all the code where we are converting Bboxes in place too. |
|
@divyashreepathihalli I think that is a good idea, do you think there is a good (efficient) way to find out such places in the code? If not, I could do that manually. |
|
Haha! we would have to do it manually. It is of a lower priority atm. I will go ahead and merge this PR for now and you can open a new PR for the rest of the code if you would like. |
divyashreepathihalli
approved these changes
Dec 27, 2023
divyashreepathihalli
merged commit 18b29be
into
keras-team:master
9 of 10 checks passed
yuvraj-wale
pushed a commit
to yuvraj-wale/keras-cv
that referenced
this pull request
Feb 8, 2024
* chore: copy the original boxes and apply convert format * chore: renaming variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2201
CC: @divyashreepathihalli