-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Yolov8 detector] Fix example in docstring #2082
[Yolov8 detector] Fix example in docstring #2082
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! Looks good -- just one little tweak
@@ -362,13 +362,24 @@ class YOLOV8Detector(Task): | |||
], | |||
"classes": [[1, 1, 1]], | |||
} | |||
|
|||
# Convert labels to tensors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of this, why don't we just add tf.constant calls above on lines 356+363?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah true, fixed it. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
* fix example in docstring * review comments
* fix example in docstring * review comments
What does this PR do?
--
yolo_v8_m_coco
toyolo_v8_m_backbone_coco
--
fpn_depth=2.
tofpn_depth=2
model.fit
-- Converted
labels
tolabels_tensor
.--
model.fit(images, labels)
tomodel.fit(images, labels_tensor)
Who can review?
@ianstenbit @jbischof