Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics-operator): use v1 API in operator logic #3269

Merged
merged 5 commits into from
Mar 21, 2024
Merged

feat(metrics-operator): use v1 API in operator logic #3269

merged 5 commits into from
Mar 21, 2024

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Mar 14, 2024

Fixes: #3239

Depends on #3266

@github-actions github-actions bot added documentation Improvements or additions to documentation ops metrics-operator labels Mar 14, 2024
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.06%. Comparing base (d034a4f) to head (4ddec1b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3269      +/-   ##
==========================================
- Coverage   87.09%   87.06%   -0.03%     
==========================================
  Files         168      168              
  Lines        8723     8723              
==========================================
- Hits         7597     7595       -2     
- Misses        835      837       +2     
  Partials      291      291              
Files Coverage Δ
...ollers/common/providers/keptnmetric/keptnmetric.go 90.90% <100.00%> (ø)
metrics-operator/api/v1/analysis_types.go 100.00% <ø> (ø)
metrics-operator/api/v1/analysis_webhook.go 89.74% <ø> (ø)
...etrics-operator/api/v1/analysisdefinition_types.go 100.00% <ø> (ø)
...rics-operator/api/v1/analysisdefinition_webhook.go 82.81% <100.00%> (ø)
...ics-operator/api/v1/analysisvaluetemplate_types.go 100.00% <ø> (ø)
metrics-operator/api/v1/keptnmetric_types.go 100.00% <ø> (ø)
metrics-operator/api/v1/keptnmetric_webhook.go 93.75% <ø> (ø)
...rics-operator/api/v1/keptnmetricsprovider_types.go 66.66% <ø> (ø)
metrics-operator/api/v1beta1/analysis_types.go 100.00% <ø> (ø)
... and 27 more

... and 2 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 69.23% <ø> (ø)
component-tests 58.77% <ø> (+0.40%) ⬆️
lifecycle-operator 86.50% <100.00%> (ø)
metrics-operator 88.35% <100.00%> (ø)
scheduler 34.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
Copy link

sonarcloud bot commented Mar 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud

@odubajDT odubajDT marked this pull request as ready for review March 21, 2024 09:26
@odubajDT odubajDT requested a review from a team as a code owner March 21, 2024 09:26
@odubajDT odubajDT removed the on hold Do not merge yet label Mar 21, 2024
@mowies mowies changed the title feat(metrics-operator)!: use v1 API in operator logic feat(metrics-operator): use v1 API in operator logic Mar 21, 2024
Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@odubajDT odubajDT merged commit e9a584b into keptn:main Mar 21, 2024
47 checks passed
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
Signed-off-by: vickysomtee <vickysomtee@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lifecycle-operator metrics-operator ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change hub version to v1, adapt conversion webhooks, use in controllers
3 participants