Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect URL of plugin site #4

Open
strarsis opened this issue Oct 28, 2019 · 2 comments
Open

Incorrect URL of plugin site #4

strarsis opened this issue Oct 28, 2019 · 2 comments
Assignees

Comments

@strarsis
Copy link

strarsis commented Oct 28, 2019

The URL of plugin site of Glossary plugin is incorrect and leads to a non-existing GitHub repository (https://github.com/kellymears/wp-block-glossary/ instead of https://github.com/pixelcollective/glossary).

Additonally it seems that the composer package name tinypixel/block-glossary doesn't reflect the repository name kellymears/wp-block-glossary.

@strarsis
Copy link
Author

strarsis commented Nov 1, 2019

So the package name block-glossary is indeed the cause of the issue because the plugin folder is expected to be wp-block-glossary, which also means this is somewhere unusually hardcoded, see https://github.com/kellymears/wp-block-glossary/blob/master/wp-block-glossary.php#L31.

@kellymears
Copy link
Owner

Submit a pr and I’ll merge it.

@kellymears kellymears self-assigned this Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants