fix reviews

CHANGELOG.md

@@ -8,7 +8,7 @@
 - feat(rpc): added `get_state_update` real values from DA db
 - feat: add transparent representation to `Felt252Wrapper`
 - feat(rpc/trace_api): add `trace_block_transaction`
-- chore(runtime_api): remove unused `filter_extrinsic`
+- chore(db): changed the way hashes are encoded
 
 ## v0.7.0
 

crates/runtime/src/lib.rs

@@ -338,7 +338,7 @@ impl_runtime_apis! {
                 _ => unreachable!("The previous match made sure that at this point tx is one of those starknet calls"),
             };
 
-            let tx_index = u32::try_from(tx_index).expect("unexpected number of transactions");
+            let tx_index = u32::try_from(tx_index).expect("More that u32::MAX extrinsics have been passed. That's too much. You should not be doing that.");
             Some((tx_index, transaction))
         }
 

starknet-rpc-test/Cargo.toml

@@ -119,5 +119,5 @@ name = "starknet_get_state_update"
 path = "get_state_update.rs"
 
 [[test]]
-name = "starknet_trance_block"
+name = "starknet_trace_block_transactions"
 path = "trace_block.rs"

starknet-rpc-test/trace_block.rs

@@ -31,7 +31,7 @@ async fn fail_non_existing_block(madara: &ThreadSafeMadaraClient) -> Result<(),
 
 #[rstest]
 #[tokio::test]
-async fn work(madara: &ThreadSafeMadaraClient) -> Result<(), anyhow::Error> {
+async fn work_for_one_invoke_tx(madara: &ThreadSafeMadaraClient) -> Result<(), anyhow::Error> {
     let rpc = madara.get_starknet_client().await;
 
     // Create a block with one tx