Add favicon to kedro-viz documentation

[Huongg]

Description

Fixes #1724 , as a part of the ticket is to add the favicon to our documentation. Ideally we should do it directly in kedro-sphinx-theme.

However @astrojuanlu pointed out that there's some issue with Sphinx theme don't normally have their own conf.py (issue here), therefore the fix for now will be directly inside kedro-viz doc, and the same for kedro datasets

The favicon is now shown through the doc build https://kedro--1959.org.readthedocs.build/projects/kedro-viz/en/1959/

Checklist

• Read the contributing guidelines
• Opened this PR as a 'Draft Pull Request' if it is work-in-progress
• Updated the documentation to reflect the code changes
• Added new entries to the RELEASE.md file
• Added tests to cover my changes

[astrojuanlu]

LGTM!

[jitu5]

@Huongg Is it possible to add favicon locally from repo instead of downloading from https://kedro.org/images/favicon.ico

[Huongg]

hey @jitu5 it's possible but it means we have to do the same download for framework and kedro-datasets, at the moment 3 repos are using the same image from the link

[ravi-kumar-pilla]

I feel having it in one place for all the repos is easy for maintenance. Also, where are we actually downloading this favicon, here we are just defining the source. Do you know where is the download code ? or does sphinx do it internally

[jitu5]

If we are already following this then its fine. I just asked because if the link somehow gets broken, it will break everywhere, and we won't know about it.

[Huongg]

@ravi-kumar-pilla it's just accessing the link, so the proper fix will be to get all of this handled inside kedro-sphinx-theme but it requires a lot of investigation i think. Juanlu has already opened the ticket for it so hopefully we get it fixed soon

[SajidAlamQB]

Thank you @Huongg!

[ravi-kumar-pilla]

LGTM 👍 ... thank you @Huongg