Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Packaging Pin to >=23.0 #1947

Closed
wants to merge 2 commits into from
Closed

Update Packaging Pin to >=23.0 #1947

wants to merge 2 commits into from

Conversation

rxm7706
Copy link
Contributor

@rxm7706 rxm7706 commented Jun 14, 2024

Description

resolves #1946

Development notes

QA notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

@rxm7706
Update Packaging Pin to >=23.0
9a065e3 
Signed-off-by: rxm7706 <95496360+rxm7706@users.noreply.github.com>
@rxm7706
Added entry to the RELEASE.md file
bcb800a 
Signed-off-by: rxm7706 <95496360+rxm7706@users.noreply.github.com>
@rxm7706 rxm7706 marked this pull request as ready for review June 14, 2024 02:19
@astrojuanlu
Copy link
Member

cc @ravi-kumar-pilla

@ravi-kumar-pilla
Copy link
Contributor

Hi @rxm7706 , Thank you for the PR. Could you please add more information on #1946 .

Details like -

  1. How this bug affects your application
  2. How can we reproduce this bug on our end
  3. Your application environment (Kedro-Viz and python version, OS and version)
  4. Any other details you feel would help us in debugging

These details would help us to understand the root cause and fix any future issues. Thank you !

deepyaman
deepyaman approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@deepyaman deepyaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor comment; otherwise, sounds good to me, to be able to get latest packaging!

RELEASE.md Show resolved Hide resolved
@rxm7706 rxm7706 closed this by deleting the head repository Jun 20, 2024
@astrojuanlu
Copy link
Member

hey @rxm7706, do you still intend to pursue this?

@rxm7706
Copy link
Contributor Author

rxm7706 commented Jun 20, 2024

hey @rxm7706, do you still intend to pursue this?

@astrojuanlu - Yes, please. . I will open another PR to address.

@rxm7706
Copy link
Contributor Author

rxm7706 commented Jun 20, 2024

hey @rxm7706, do you still intend to pursue this?

@astrojuanlu - Yes, please. . I will open another PR to address.

continued - #1953

@SajidAlamQB SajidAlamQB mentioned this pull request Jul 25, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepyaman deepyaman deepyaman approved these changes

@rashidakanchwala rashidakanchwala Awaiting requested review from rashidakanchwala rashidakanchwala is a code owner

@astrojuanlu astrojuanlu Awaiting requested review from astrojuanlu astrojuanlu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update packaging pin in requirements.txt from ~=23.0 to >=23.0
4 participants
@rxm7706 @astrojuanlu @ravi-kumar-pilla @deepyaman