Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Kedro-viz experience on notebooks #1722

Merged
merged 4 commits into from
Feb 5, 2024
Merged

Improve Kedro-viz experience on notebooks #1722

merged 4 commits into from
Feb 5, 2024

Conversation

SajidAlamQB
Copy link
Contributor

@SajidAlamQB SajidAlamQB commented Jan 29, 2024 •
edited
Loading

Description

When using the %run_viz command for kedro-viz in Jupyter notebooks, it should open Kedro-viz in a new browser tab.

Development notes

image

When clicking Open Kedro-Viz a new tab is opened:

image

QA notes

Added one new unit tests that checks the target attribute is set to _blank, and the link text is Open Kedro-Viz.

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

@SajidAlamQB SajidAlamQB self-assigned this Jan 29, 2024
@SajidAlamQB
add test and lint
46db193 
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
@SajidAlamQB SajidAlamQB marked this pull request as ready for review January 30, 2024 14:30
@SajidAlamQB SajidAlamQB linked an issue Jan 30, 2024 that may be closed by this pull request
Improve Kedro-viz experience on notebooks. #1668
Closed
1 task
@astrojuanlu
Copy link
Member

I notice in the screenshot that you're using an old version of Jupyter notebook, @SajidAlamQB could you try with notebook>=7.0? It was completely refactored and it's now based on JupyterLab internally.

@SajidAlamQB
Copy link
Contributor Author

I notice in the screenshot that you're using an old version of Jupyter notebook, @SajidAlamQB could you try with notebook>=7.0? It was completely refactored and it's now based on JupyterLab internally.

Here is what it looks like with notebook>=7.0:

image

image

rashidakanchwala
rashidakanchwala approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@rashidakanchwala rashidakanchwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look's great. Thanks Sajid! :)

merelcht
merelcht approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Should this change be included in the release notes?

@SajidAlamQB
Update RELEASE.md
38318a3 
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
@SajidAlamQB SajidAlamQB merged commit 882f35c into main Feb 5, 2024
17 checks passed
@SajidAlamQB SajidAlamQB deleted the improve-notebook-exp branch February 5, 2024 12:27
santana98 pushed a commit to santana98/kedro-viz that referenced this pull request Feb 19, 2024
@SajidAlamQB @santana98
Improve Kedro-viz experience on notebooks (kedro-org#1722)
5604c9d 
* Add link to open in new tab

* add test and lint

Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>

* Update RELEASE.md

Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>

---------

Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
Signed-off-by: Elias Santana <eliasvssantana@gmail.com>
@ravi-kumar-pilla ravi-kumar-pilla mentioned this pull request Mar 1, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rashidakanchwala rashidakanchwala rashidakanchwala approved these changes

@merelcht merelcht merelcht approved these changes

@jitu5 jitu5 Awaiting requested review from jitu5

@NeroOkwa NeroOkwa Awaiting requested review from NeroOkwa

@ravi-kumar-pilla ravi-kumar-pilla Awaiting requested review from ravi-kumar-pilla ravi-kumar-pilla is a code owner

@tynandebold tynandebold Awaiting requested review from tynandebold

@yetudada yetudada Awaiting requested review from yetudada

Assignees

@SajidAlamQB SajidAlamQB

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Kedro-viz experience on notebooks.
4 participants
@SajidAlamQB @astrojuanlu @rashidakanchwala @merelcht