Make kedro viz build compatible with Kedro 18
#1716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rashidakanchwala
requested review from
jitu5,
ravi-kumar-pilla,
merelcht,
ankatiyar and
SajidAlamQB
and removed request for
merelcht
ravi-kumar-pilla
approved these changes
Jan 24, 2024
SajidAlamQB
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you are using Kedro 18 and attempting to use the newly introduced
kedro viz buildfeature, it will fail. This PR resolves this issue.Development notes
The issue arises because Kedro 18 only accepts
Pathsand notstringsas arguments to theget_protocol_and_path()function. This behavior change was introduced in PR #3345. To make get_protocol_and_path() work with both Kedro 18 and 19, we have reinforced casting to a string when calling this function from kedro-core.QA notes
Checklist
RELEASE.mdfile