Kedro Viz Static Website hosting on Azure #1708

ravi-kumar-pilla · 2024-01-17T08:48:53Z

Description

Resolves #1674

Development notes

Added Kedro Viz Static Website hosting support for Azure
Moved optional dependencies namely s3fs and adlfs to setup.py -> extras_require. This will help users to install platform specific dependencies based on the cloud platform. For example pip install 'kedro-viz[aws]' will install aws deployer specific dependencies
Added pytests for AzureDeployer and updated previous pytests to accept new deployer inputs

NOTE: There will be a new PR to update documentation for shareable-viz

QA notes

Setup Environment for Azure

Route 1 - Authorizing via Azure ServicePrincipal  

What users need to do - Create Storage Account + App Registration + Role permissions

On Azure portal

Create an App registration
Copy App registration parameters (Application (Client) ID, Directory (Tenant) ID)
Create and copy Client secret (Client Secret Value)
Create a Storage Account and configure it for static website hosting -
Create a storage container
Assign app and role to the storage account (assign a role of Storage Blob Data Contributor to the app registered)

On command line before running kedro viz deploy

Add environment variables - AZURE_STORAGE_CLIENT_ID (which is the application id in step2), AZURE_STORAGE_TENANT_ID (which is Directory ID in step2), AZURE_STORAGE_CLIENT_SECRET (which is the client secret value in step3)

Route 2 - Using Account Key

What users need to do - Create Storage Account

On Azure portal

Create a Storage Account and configure it for static website hosting - https://learn.microsoft.com/en-us/azure/storage/blobs/storage-blob-static-website-host
Copy the Account key from Security + Networking tab under storage account created in step 1

On command line before running kedro viz deploy

Add environment variable - AZURE_STORAGE_ACCOUNT_KEY (which is the account key value in step2)

Run deploy command
kedro viz deploy --platform=azure --endpoint=https://example-bucket.z13.web.core.windows.net/ --bucket-name=example-bucket

Note:

Bucket name is the storage account name
Endpoint (Primary endpoint) can be found in the Storage account -> Capabilities -> Static Website Hosting
For static website hosting $web is the default container that is created under the storage account. We will upload all the kedro viz files to this container (This container is mandatory for shareableviz)

Checklist

Read the contributing guidelines
Opened this PR as a 'Draft Pull Request' if it is work-in-progress
Updated the documentation to reflect the code changes
Added new entries to the RELEASE.md file
Added tests to cover my changes

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

astrojuanlu · 2024-01-25T17:24:46Z

Is there a way to slice these pull requests?

reviewing +730,-410 lines of changes is quite a lot and I think it increases the risk of overlooking possible mistakes.

rashidakanchwala · 2024-01-25T17:49:16Z

Is there a way to slice these pull requests?

reviewing +730,-410 lines of changes is quite a lot and I think it increases the risk of overlooking possible mistakes.

the only way we could slice this PR was keep FE and BE seperate. There's some refactoring work which could be removed and put in another PR but it's very minimal. If you like, Ravi or I can quickly give you an overview which will help with the review.

ravi-kumar-pilla · 2024-01-26T03:01:27Z

Is there a way to slice these pull requests?

reviewing +730,-410 lines of changes is quite a lot and I think it increases the risk of overlooking possible mistakes.

Hi @astrojuanlu , I tried to make this in 2 PRs but the tests were failing. May be you can give a 2 pass review. There are test files which can be reviewed in the 2nd pass. But, I agree there are lot of changes in this single PR.

merelcht · 2024-01-26T11:14:40Z

the only way we could slice this PR was keep FE and BE seperate. There's some refactoring work which could be removed and put in another PR but it's very minimal.

This is certainly not true. There's many ways in which this PR could have been built up, introducing the deployers separately would already have been 1 step. Of course, this involves more work, but the trade off you make with PRs is the following: small easy to follow PRs will be quick to review and will get merged faster, large PRs such as this one require much longer time to review and thus in the end the work will take a lot longer to merge. Ensuring high quality is also harder with big PRs, because it's much easier to miss things.

rashidakanchwala · 2024-01-26T11:16:02Z

Yes, now that I am slicing it the refactor is quite a lot. I will release the refactor PR shortly. Thanks for pushing back on this.

…ature/shareableviz-az Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

noklam · 2024-02-12T12:18:24Z

package/kedro_viz/integrations/deployment/azure_deployer.py

+
+from kedro_viz import __version__
+
+_AZ_PROTOCOL = "abfs"


Can we reused logic from kedro? I don't think abfs is the only protocols supported by Azure. See https://github.com/fsspec/adlfs

Here we are using Gen2 filesystem to build the remote path (we will mention this in our docs that azure deployment is supported with gen2 filesystem). Could you please point me to what reuse logic from kedro you are referring to ? Thank you

https://github.com/kedro-org/kedro/blob/80ad182a220d691c77efc05cc4e2b36dcecb6ac7/kedro/io/core.py#L711
95% identical to fsspec to handle some extra edge cases. If this only support abfs it is fine too, but worth mentioning in the docs.

noklam · 2024-02-12T12:18:49Z

package/kedro_viz/integrations/deployment/azure_deployer.py

+        super().__init__()
+        self._endpoint = endpoint
+        self._bucket_name = bucket_name
+        self._path = f"{_AZ_PROTOCOL}://$web"


What is $web?

$web is the default container in AzureBlobStorage when someone enables static website hosting. We will mention this in the docs that the users need to have this container to use static hosting.

noklam · 2024-02-12T12:23:13Z

package/setup.py

+        "aws": ["s3fs>=2021.4,<2024.1"],
+        "azure": ["adlfs>=2021.4,<2024.1"],


Is there any documentation explains why this pin differently from kedro? It would be nice even if it's just an in-line comment. Some users were asking why this is pinned, from my understanding it only affect kedro-viz user who is using the static site deployment.

sure, the issue was files were being copied differently from fsspec>=2024.1. The project structure was not maintained. But, you are right I will try to see if we can remove the upperbound, if not will document this with a comment here and also in the deployment docs. Thank you !

Hi @noklam , I tested with the latest version of fsspec, s3fs and adlfs. The deployment seems to work fine. I would request @jitu5 to test it and confirm. If it works fine, we will drop the upperbound and sync it with kedro. Thanks for pointing this 👍

@ravi-kumar-pilla I tested with the latest version of fsspec, s3fs and adlfs and its works fine for me.

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

* refactor router to accept new deployer inputs (#1739) Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * Refactor Shareableviz CLI (#1740) * refactor router to accept new deployer inputs Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * refactor cli for shareableviz deploy Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * merge router change Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * PR comments fix Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> --------- Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * Kedro Viz Static Website hosting on Azure (#1708) * CLI command kedro viz build added * Lint fix * lint fix * Lint fix * add mypy ignore * Missing build file added * Lint error fix * BaseDeployer class added * Unused code removed * Fix lint issue * azure deploy initial draft Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * added base_deployer * add deployer factory * partial working draft Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * Test and comments of deployers updated * test draft Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * fix lint Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * remove circular dependency Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * fix lint Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * revert back consent Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * minor updates Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * update pytests Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * add pytest for azure shareableviz Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * refactor and add timeout Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * refactor cli Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * update pytest Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * add release note Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * fix flaky test Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * fix PR comments and flaky test Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * testing flaky c y test Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * remove flaky test Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * resolve conflicts Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * fix PR comments Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * add back cypress flaky test Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * remove cypress flaky test Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * remove duplicate pytest parameter Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * remove fsspec upper bound Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> --------- Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> Co-authored-by: Jitendra Gundaniya <jitendra_gundaniya@mckinsey.com> Co-authored-by: rashidakanchwala <rashida_kanchwala@mckinsey.com> * Kedro Viz Static Website Hosting on GCP (#1711) * CLI command kedro viz build added * Lint fix * lint fix * Lint fix * add mypy ignore * Missing build file added * Lint error fix * BaseDeployer class added * Unused code removed * Fix lint issue * azure deploy initial draft Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * added base_deployer * add deployer factory * partial working draft Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * Test and comments of deployers updated * test draft Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * fix lint Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * remove circular dependency Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * fix lint Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * revert back consent Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * initial draft Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * minor updates Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * update pytests Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * add pytest for azure shareableviz Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * refactor and add timeout Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * refactor cli Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * update pytest Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * add release note Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * fix flaky test Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * fix PR comments and flaky test Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * testing flaky c y test Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * remove flaky test Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * add pytest for gcp Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * fix gcp pytest coverage Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * fix lint Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * update pytest Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * revert file permission change --------- Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> Co-authored-by: Jitendra Gundaniya <jitendra_gundaniya@mckinsey.com> Co-authored-by: rashidakanchwala <rashida_kanchwala@mckinsey.com> * Sharable Kedro-Viz UI for AWS, GCP and Azure (#1718) * shareable viz with multiple platform UI * test fix * Relative path fix for user entered url * Test updated * Test updated * UI alignment and endpoint help text added. Signed-off-by: <> * Add Kedro-Viz documentation URLs and update modal content Signed-off-by: <> * Code review suggestions added Signed-off-by: <> * Refactor form field names in ShareableUrlModal component Signed-off-by: <> * Add cursor style to input field in shareable-url-modal.js Signed-off-by: <> * Add cursor style to input field in shareable-url-modal.js Signed-off-by: <> * Variable names updated. Signed-off-by: <> * add exception handlers Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * Disclaimer note added and shareable-url-modal component refactored by moving major jsx to other file Signed-off-by: <> * Wrapped the prop methods with useCallback Signed-off-by: <> * info text updated. Signed-off-by: <> * Test fixed Signed-off-by: <> * test fix and rearranging jsx Signed-off-by: <> * Cypress test fix Signed-off-by: <> * button text updated Signed-off-by: <> * Keeping button text as Publish for a link seetings Signed-off-by: <> --------- Signed-off-by: <> Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> Co-authored-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * Kedro-viz doc link added in disclaimer note. Signed-off-by: <> --------- Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> Signed-off-by: <> Co-authored-by: Jitendra Gundaniya <jitendra_gundaniya@mckinsey.com> Co-authored-by: rashidakanchwala <rashida_kanchwala@mckinsey.com> Co-authored-by: Jitendra Gundaniya <38945204+jitu5@users.noreply.github.com>

…dular pipelines flag (#1799) * shareable viz with multiple platform UI * test fix * Relative path fix for user entered url * Test updated * Test updated * refactor router to accept new deployer inputs (#1739) Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * Refactor Shareableviz CLI (#1740) * refactor router to accept new deployer inputs Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * refactor cli for shareableviz deploy Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * merge router change Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * PR comments fix Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> --------- Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * Kedro Viz Static Website hosting on Azure (#1708) * CLI command kedro viz build added * Lint fix * lint fix * Lint fix * add mypy ignore * Missing build file added * Lint error fix * BaseDeployer class added * Unused code removed * Fix lint issue * azure deploy initial draft Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * added base_deployer * add deployer factory * partial working draft Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * Test and comments of deployers updated * test draft Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * fix lint Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * remove circular dependency Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * fix lint Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * revert back consent Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * minor updates Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * update pytests Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * add pytest for azure shareableviz Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * refactor and add timeout Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * refactor cli Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * update pytest Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * add release note Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * fix flaky test Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * fix PR comments and flaky test Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * testing flaky c y test Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * remove flaky test Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * resolve conflicts Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * fix PR comments Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * add back cypress flaky test Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * remove cypress flaky test Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * remove duplicate pytest parameter Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * remove fsspec upper bound Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> --------- Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> Co-authored-by: Jitendra Gundaniya <jitendra_gundaniya@mckinsey.com> Co-authored-by: rashidakanchwala <rashida_kanchwala@mckinsey.com> * Kedro Viz Static Website Hosting on GCP (#1711) * CLI command kedro viz build added * Lint fix * lint fix * Lint fix * add mypy ignore * Missing build file added * Lint error fix * BaseDeployer class added * Unused code removed * Fix lint issue * azure deploy initial draft Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * added base_deployer * add deployer factory * partial working draft Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * Test and comments of deployers updated * test draft Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * fix lint Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * remove circular dependency Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * fix lint Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * revert back consent Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * initial draft Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * minor updates Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * update pytests Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * add pytest for azure shareableviz Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * refactor and add timeout Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * refactor cli Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * update pytest Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * add release note Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * fix flaky test Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * fix PR comments and flaky test Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * testing flaky c y test Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * remove flaky test Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * add pytest for gcp Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * fix gcp pytest coverage Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * fix lint Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * update pytest Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * revert file permission change --------- Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> Co-authored-by: Jitendra Gundaniya <jitendra_gundaniya@mckinsey.com> Co-authored-by: rashidakanchwala <rashida_kanchwala@mckinsey.com> * Initial commit * Set query params from local storage on load * Test fix * test fix * Test fixes * Some method docs added. * Shortening existing URL query params focused_id, selected_id, selected_name and pipeline_id * Fix experiment tracking search query test * Clear filter button added * Missing test added * Release note added * Clear to Reset * Release note & retain qparams updated * fixes * almost done * missing nodeTypes added * URL Params handling moved to user-generated-pathname.js * Review suggestion added * getKeysByValue moved * updateStateWithFilters renamed * Reset button status check removed * Reset buton status test removed * Reset button status check revert * Reset button UI update * code review suggestions for reset button status * state compare for nodeTypes * On group filter click fix * Task to node mapping added * All nodeTypes match UI labels with URLparmas * Removed console.log * modified test as per query param name update --------- Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> Co-authored-by: Ravi Kumar Pilla <ravi_kumar_pilla@mckinsey.com> Co-authored-by: rashidakanchwala <rashida_kanchwala@mckinsey.com>

jitu5 and others added 30 commits January 4, 2024 15:46

CLI command kedro viz build added

66f177d

Lint fix

cc7c144

lint fix

a389a83

Lint fix

6528d36

add mypy ignore

5a9f2e1

Missing build file added

b86b578

Lint error fix

40003f8

BaseDeployer class added

0c879a8

Unused code removed

5145ba4

Fix lint issue

26f6275

azure deploy initial draft

52827c2

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

added base_deployer

c7ed79c

latest

11ac321

add deployer factory

42af3af

partial working draft

aff36ec

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

Test and comments of deployers updated

7ad0905

test draft

0ff98a2

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

fix lint

2a4e00f

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

remove circular dependency

ecb6a05

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

merge build

39418aa

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

merge main and modify azure deployer

b18d547

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

fix lint

8b504fb

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

revert back consent

9d683aa

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

minor updates

2655d1a

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

update pytests

2ac04fd

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

add pytest for azure shareableviz

c258ec1

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

refactor and add timeout

44241ca

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

merge main

40df81e

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

refactor cli

c9e2436

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

update pytest

9c31fc4

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

rashidakanchwala changed the base branch from feature/shareableviz-extended-support to refactor-deployerclass January 26, 2024 11:32

rashidakanchwala marked this pull request as draft January 26, 2024 11:34

jitu5 mentioned this pull request Jan 26, 2024

Sharable Kedro-Viz UI for AWS, GCP and Azure #1718

Merged

5 tasks

ravi-kumar-pilla mentioned this pull request Feb 6, 2024

Refactor Shareableviz REST endpoint #1739

Merged

5 tasks

ravi-kumar-pilla changed the base branch from refactor-deployerclass to chore/refactor-shareableviz-router February 6, 2024 18:07

Merge branch 'main' of https://github.com/kedro-org/kedro-viz into fe…

9b9478a

…ature/shareableviz-az Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

ravi-kumar-pilla mentioned this pull request Feb 6, 2024

Refactor Shareableviz CLI #1740

Merged

5 tasks

ravi-kumar-pilla changed the base branch from chore/refactor-shareableviz-router to chore/refactor-shareableviz-cli February 6, 2024 19:32

Base automatically changed from chore/refactor-shareableviz-cli to feature/shareableviz-extended-support February 8, 2024 16:55

ravi-kumar-pilla added 3 commits February 8, 2024 11:11

merge extended support

bce7258

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

add back cypress flaky test

c27f419

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

remove cypress flaky test

496c2c4

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

ravi-kumar-pilla marked this pull request as ready for review February 8, 2024 17:55

ravi-kumar-pilla requested a review from merelcht February 8, 2024 17:56

remove duplicate pytest parameter

bb2e6a9

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

noklam reviewed Feb 12, 2024

View reviewed changes

remove fsspec upper bound

cd05c91

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

noklam self-requested a review February 13, 2024 14:04

noklam approved these changes Feb 13, 2024

View reviewed changes

ravi-kumar-pilla merged commit 25a7aff into feature/shareableviz-extended-support Feb 13, 2024
17 checks passed

ravi-kumar-pilla deleted the feature/shareableviz-az branch February 13, 2024 15:09

ravi-kumar-pilla mentioned this pull request Feb 22, 2024

Shareableviz extended support #1749

Merged

5 tasks

ravi-kumar-pilla mentioned this pull request Mar 1, 2024

Release v8.0.0 #1781

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Kedro Viz Static Website hosting on Azure #1708

Kedro Viz Static Website hosting on Azure #1708

ravi-kumar-pilla commented Jan 17, 2024 •

edited

Loading

astrojuanlu commented Jan 25, 2024

rashidakanchwala commented Jan 25, 2024

ravi-kumar-pilla commented Jan 26, 2024

merelcht commented Jan 26, 2024

rashidakanchwala commented Jan 26, 2024

noklam Feb 12, 2024

ravi-kumar-pilla Feb 12, 2024

noklam Feb 13, 2024

noklam Feb 12, 2024

ravi-kumar-pilla Feb 12, 2024

noklam Feb 12, 2024

ravi-kumar-pilla Feb 12, 2024

ravi-kumar-pilla Feb 13, 2024

jitu5 Feb 13, 2024

		"aws": ["s3fs>=2021.4,<2024.1"],
		"azure": ["adlfs>=2021.4,<2024.1"],

Kedro Viz Static Website hosting on Azure #1708

Kedro Viz Static Website hosting on Azure #1708

Conversation

ravi-kumar-pilla commented Jan 17, 2024 • edited Loading

Description

Development notes

QA notes

Checklist

astrojuanlu commented Jan 25, 2024

rashidakanchwala commented Jan 25, 2024

ravi-kumar-pilla commented Jan 26, 2024

merelcht commented Jan 26, 2024

rashidakanchwala commented Jan 26, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ravi-kumar-pilla commented Jan 17, 2024 •

edited

Loading