Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Metadata timestamp for Shareable Viz #1679

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Fix Metadata timestamp for Shareable Viz #1679

merged 2 commits into from
Dec 12, 2023

Conversation

ravi-kumar-pilla
Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla commented Dec 12, 2023 •
edited
Loading

Description

Fix for timestamp not appearing in shareable viz

Development notes

  • Moved the shareable url metadata inside kedro pipeline div to make it visible

QA notes

  • Deploy Kedro Viz and you should see the version and deployed timestamp on the screen
image

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

@ravi-kumar-pilla
fix metadata timestamp for shareableviz
7f57a78 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla ravi-kumar-pilla marked this pull request as ready for review December 12, 2023 14:21
rashidakanchwala
rashidakanchwala approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@rashidakanchwala rashidakanchwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!!

@ravi-kumar-pilla ravi-kumar-pilla merged commit e36be71 into main Dec 12, 2023
5 checks passed
@ravi-kumar-pilla ravi-kumar-pilla deleted the fix/metadata-timestamp branch December 12, 2023 17:45
@rashidakanchwala rashidakanchwala mentioned this pull request Dec 19, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rashidakanchwala rashidakanchwala rashidakanchwala approved these changes

@tynandebold tynandebold Awaiting requested review from tynandebold

@jitu5 jitu5 Awaiting requested review from jitu5 jitu5 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ravi-kumar-pilla @rashidakanchwala