Skip to content

Commit

Permalink
fix abstract instantiate issue
Browse files Browse the repository at this point in the history
  • Loading branch information
ravi-kumar-pilla committed Aug 6, 2024
1 parent 0a5d1ae commit 026e0f6
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
5 changes: 3 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,11 @@ format-check:

lint-check:
pylint --rcfile=package/.pylintrc -j 0 package/kedro_viz
pylint --rcfile=package/.pylintrc -j 0 --disable=protected-access,missing-docstring,redefined-outer-name,invalid-name,too-few-public-methods,no-member,unused-argument,duplicate-code package/tests
pylint --rcfile=package/.pylintrc -j 0 --disable=protected-access,missing-docstring,redefined-outer-name,invalid-name,too-few-public-methods,no-member,unused-argument,duplicate-code,abstract-class-instantiated package/tests
pylint --rcfile=package/.pylintrc -j 0 --disable=missing-docstring,no-name-in-module,unused-argument package/features
flake8 --config=package/.flake8 package
mypy --config-file=package/mypy.ini package
mypy --config-file=package/mypy.ini package/kedro_viz package/features
mypy --disable-error-code abstract --config-file=package/mypy.ini package/tests

schema-fix:
strawberry export-schema --app-dir=package kedro_viz.api.graphql.schema > src/apollo/schema.graphql
Expand Down
2 changes: 1 addition & 1 deletion demo-project/.telemetry
Original file line number Diff line number Diff line change
@@ -1 +1 @@
consent: true
consent: false
3 changes: 2 additions & 1 deletion package/kedro_viz/data_access/repositories/catalog.py
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,8 @@ def get_dataset(self, dataset_name: str) -> Optional["AbstractDataset"]:
else: # pragma: no cover
dataset_obj = self._catalog._get_dataset(dataset_name)
except DatasetNotFoundError:
dataset_obj = MemoryDataset()
# pylint: disable=abstract-class-instantiated
dataset_obj = MemoryDataset() # type: ignore[abstract]

return dataset_obj

Expand Down

0 comments on commit 026e0f6

Please sign in to comment.