Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate CRD manifest #2726

Closed
ishioni opened this issue Mar 8, 2022 · 6 comments · Fixed by #4814
Closed

Separate CRD manifest #2726

ishioni opened this issue Mar 8, 2022 · 6 comments · Fixed by #4814
Labels
feature-request All issues for new features that have not been committed to help wanted Looking for support from community needs-discussion stale-bot-ignore All issues that should not be automatically closed by our stale bot

Comments

@ishioni
Copy link

ishioni commented Mar 8, 2022

Proposal

I would like a separate CRD-only yaml to deploy CRDs tak keda uses

Use-Case

I manage my cluster with flux, using their helmrelease CRDs and kustomize. This works fine but on the condition that CRDs are deployed on a separate step before the actual helm release. This is to combat the fact that helm releases in a kustomization step are run in parallel, and if any of them include keda resources, they will obviously fail until keda itself is installed.

Installing only the CRDs in a separate step neatly fixes this. Most projects that use CRDs that I've encountered (cert-manager, tigera) offer separate CRD yamls knowing that helm-managed CRDs are iffy

Anything else?

No response

@ishioni ishioni added feature-request All issues for new features that have not been committed to needs-discussion labels Mar 8, 2022
@tomkerkhove
Copy link
Member

Would you prefer to have them as a YAML file in that case?

@ishioni
Copy link
Author

ishioni commented Mar 9, 2022

Yes, that would be ideal

@tomkerkhove
Copy link
Member

Any thoughts on this @zroubalik?

@zroubalik
Copy link
Member

zroubalik commented Mar 10, 2022

Fine for me, the CRDs are already part of the big keda-2.X.X.yaml (eg. https://github.com/kedacore/keda/releases/download/v2.6.1/keda-2.6.1.yaml), we can produce a yaml with just CRDs next to it.

The release is being done here:

- name: Release Deployment YAML file
run: make release
env:
VERSION: ${{ steps.get_version.outputs.VERSION }}

@ishioni are you willing to contribute this?

@stale
Copy link

stale bot commented May 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label May 9, 2022
@JorTurFer JorTurFer added the stale-bot-ignore All issues that should not be automatically closed by our stale bot label May 10, 2022
@stale stale bot removed the stale All issues that are marked as stale due to inactivity label May 10, 2022
@dmendres
Copy link

We have another use case. We'd like conditional deployment of the KEDA resources from a template (e.g. templates/keda.yaml) but Helm 3.x must process the CRDs in advance. We don't need conditional deployment of the CRDs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request All issues for new features that have not been committed to help wanted Looking for support from community needs-discussion stale-bot-ignore All issues that should not be automatically closed by our stale bot
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants