Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove file lists and iterators in WorkingDirectory #430

Open
ondrejhlavacek opened this issue May 17, 2019 · 0 comments
Open

remove file lists and iterators in WorkingDirectory #430

ondrejhlavacek opened this issue May 17, 2019 · 0 comments

Comments

@ondrejhlavacek
Copy link
Member

ondrejhlavacek commented May 17, 2019

eg.

        $fs = new Filesystem();
        $finder = new Finder();
        $finder->files()->in($this->workingDir . DIRECTORY_SEPARATOR . 'data');
        $fs->remove($finder);
        $fs->remove($this->workingDir . DIRECTORY_SEPARATOR . 'data');

=>

        $fs->remove($finder);
        $fs->remove($this->workingDir . DIRECTORY_SEPARATOR . 'data');

něco takovýho je ve všech metodách

a ještě by bylo dobrý zkontrolovat, jestli to z nějakýho důvodu nezůstává ležet v paměti.

a pokud to nepůjde (Filesystem::remove() to třeba může iterovat po souborech), tak pak bych tam jebnul sprostej rm -rf.

Pravděpodobně fix na #429

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant