Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(travis): Up the socket timeout 2->20s. #3103

Merged
merged 1 commit into from
Aug 7, 2018

Conversation

johnjbarton
Copy link
Contributor

Log something on all disconnect() calls.
Up the timeout as suggested by ndcornelius@ on #3102

@johnjbarton
Copy link
Contributor Author

Many of our Travis runs fail recently with disconnect errors. Maybe this will help. At least with better logging we can get some hints.

@johnjbarton johnjbarton requested a review from zzo August 7, 2018 15:38
lib/browser.js Outdated
@@ -151,15 +151,15 @@ class Browser {
}

if (this.state === CONNECTED) {
this.disconnect()
this.disconnect('client disconnected while only connected')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'client disconnected from CONNECTED state'
?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Log something on all disconnect() calls.
Up the timeout as suggested by ndcornelius@ on karma-runner#3102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants