Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch HPI to src/ layout #316

Open
karlicoss opened this issue Oct 5, 2023 · 1 comment
Open

switch HPI to src/ layout #316

karlicoss opened this issue Oct 5, 2023 · 1 comment

Comments

@karlicoss
Copy link
Owner

I'm thinking that would be nice to switch to src/ layout for consistency (and generally it tends to have less gotchas).
Should be smooth, the only concern is that it will break existing editable installations (since egg link would be pointing to /path/to/hpi_repo rather than /path/to/hpi_repo/src), unless the user reinstalls it.
I think that should be solvable just by putting a symlink from my to src/my though, and could add a warning suggesting the user to reinstall. Not sure if there are any other issues?
cc @seanbreckenridge

@seanbreckenridge
Copy link
Contributor

seanbreckenridge commented Oct 5, 2023

Yeah seems fine

One would need to git pull to update an editable install anyways, so they'd probably notice that

Will probably swap the HPI-template and my repo as well just for the consistency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants