-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Environment specific config doesn't work on v1.0.1 #1588
Comments
@brianngo313 won't look at this unless you follow this process: https://github.com/intuit/karate/wiki/How-to-Submit-an-Issue next time please provide this feedback for RC releases when we ask, e.g: https://twitter.com/KarateDSL/status/1359010765219393538 so now this may take time to fix. you are welcome to submit a PR of course |
20:58:18.081 [main] INFO com.intuit.karate.Runner - using system property 'karate.env': staging this log is suspicious... are overriding the variable within one of your tests? |
Well, sorry my bad, actually env1=staging, I anonymized my codes. Let me create a skeleton project and upload it here. Sorry for not reading the howto carefully |
Sorry for the inconvenience, I updated the issue description following the howto guide |
reopening - right now tagged as |
@brianngo313 I'm closing this as won't fix. karate now expects you to have a "root" the reason is we have started to look for here is the relevant line number: https://github.com/intuit/karate/blob/v1.0.1/karate-core/src/main/java/com/intuit/karate/Runner.java#L238 you are also welcome to submit a PR for the docs if you want that updated, but I don't see an RoI :) |
Thank @ptrthomas for your times and helps. I'm okay with What do you think about this #1599? |
@brianngo313 perfect, thanks for the PR and I merged it |
Thank you @ptrthomas |
myproject.zip
Steps to reproduce:
karate-config.js
with env specific configkarate-config-sandbox.js
users.feature
to configurable urlbaseUrl
How did I find this bug?
I'm upgrading karate v0.9.6 to v1.0.1, the env specific config was working fine but stopped working on the new version.
The text was updated successfully, but these errors were encountered: