Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isEmptyStyles for textbox #4762

Merged
merged 3 commits into from
Feb 24, 2018
Merged

isEmptyStyles for textbox #4762

merged 3 commits into from
Feb 24, 2018

Conversation

asturur
Copy link
Member

@asturur asturur commented Feb 24, 2018

IsEmptyStyles receives unwrapped lineindex, since is used during rendering.
That means that textbox class requires its own version in order to work properly.

Needs an added test.

related to #4755

@asturur
Copy link
Member Author

asturur commented Feb 24, 2018

Added textbox file for tests, since we had nothing.

@asturur asturur merged commit e70e65f into master Feb 24, 2018
@asturur asturur mentioned this pull request Feb 26, 2018
@asturur asturur deleted the fix-empty-styles branch February 26, 2018 10:05
thiagocunha pushed a commit to thiagocunha/fabric.js that referenced this pull request Nov 18, 2019
* isEMptyStyles for textbox
* added tests
* added missing file
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant