Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asturur patch 1 #2935

Merged
merged 4 commits into from
May 3, 2016
Merged

Asturur patch 1 #2935

merged 4 commits into from
May 3, 2016

Conversation

asturur
Copy link
Member

@asturur asturur commented May 3, 2016

rename an internal variable, fixed a bug.. var row was not initialized.

closes #2934 by @haloween

@haloween
Copy link

haloween commented May 3, 2016

fontFamily = _char.fontFamily; ?

@asturur
Copy link
Member Author

asturur commented May 3, 2016

Yes. for the same reason i did the first error, here was the second.
Thanks god test would stop me this time, just you came first.

@asturur asturur merged commit c491140 into fabricjs:master May 3, 2016
@asturur asturur deleted the asturur-patch-1 branch May 3, 2016 12:05
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in createSVGFontFacesMarkup function - char is a reserved keyword
2 participants